From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Hocko <mhocko@suse.com>
Cc: cve@kernel.org, linux-kernel@vger.kernel.org,
linux-cve-announce@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: CVE-2023-52734: net: sched: sch: Bounds check priority
Date: Tue, 28 May 2024 21:06:39 +0200 [thread overview]
Message-ID: <2024052824-justice-lair-14e6@gregkh> (raw)
In-Reply-To: <ZlWNaIMC3NCkIFxv@tiehlicka>
On Tue, May 28, 2024 at 09:53:12AM +0200, Michal Hocko wrote:
> Is this really soemthing that should be getting a CVE assigned?
> First the fix is incomplete - 9cec2aaffe96 ("net: sched: sch: Fix off by one in htb_activate_prios()")
Incomplete fixes are still part of a fix :)
> Second is this even real problem? https://lore.kernel.org/all/Y9V3mBmLUcrEdrTV@pop-os.localdomain/
> suggests it is not.
Ah, good catch, I didn't see that. I'll go revoke this as it's not
doing anything.
> And third, WARN_ONs are considered a real deal by CVE team because
> somebody might be running with panic_on_warn. This patch adds one!
Yes, but if you can't hit that by anything from userspace, it's not an
issue and just dead code. We'll have to wait for a future syzbot report
to prove that wrong :)
thanks for the review!
greg k-h
next prev parent reply other threads:[~2024-05-28 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2024052100-CVE-2023-52734-c8c2@gregkh>
2024-05-28 7:53 ` Michal Hocko
2024-05-28 19:06 ` Greg Kroah-Hartman [this message]
2024-05-29 7:30 ` Michal Hocko
2024-05-29 9:51 ` Greg Kroah-Hartman
2024-06-06 7:24 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024052824-justice-lair-14e6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cve@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-cve-announce@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®