mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] of: Reimplement of_(bus_)?n_(size|addr)_cells()
Date: Thu, 30 May 2024 20:03:26 -0500	[thread overview]
Message-ID: <20240530-dt-interrupt-map-fix-v1-0-2331d8732f08@kernel.org> (raw)

This series reworks the of_(bus_)?n_(size|addr)_cells() functions. They 
fail to hold the DT spinlock while accessing 'parent' pointer and don't 
hold a reference to the parent node. Neither is likely a real issue as 
most nodes are static.

With these issues fixed, we can then replace the open coded version in 
of_irq_parse_raw().

This series depends on the fixes from this series[1].

Rob

[1] https://lore.kernel.org/lkml/20240529-dt-interrupt-map-fix-v2-0-ef86dc5bcd2a@kernel.org/

---
Rob Herring (Arm) (3):
      of: Add an iterator to walk up parent nodes
      of: Add missing locking to of_(bus_)?n_(size|addr)_cells()
      of/irq: Use of_bus_n_addr_cells() to retrieve "#address-cells"

 drivers/of/base.c  | 18 ++++++++----------
 drivers/of/irq.c   | 15 +++------------
 include/linux/of.h |  5 +++++
 3 files changed, 16 insertions(+), 22 deletions(-)
---
base-commit: e7985f43609c782132f8f5794ee6cc4cdb66ca75
change-id: 20240530-dt-interrupt-map-fix-6946101b1391

Best regards,
-- 
Rob Herring (Arm) <robh@kernel.org>


             reply	other threads:[~2024-05-31  1:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31  1:03 Rob Herring (Arm) [this message]
2024-05-31  1:03 ` [PATCH 1/3] of: Add an iterator to walk up parent nodes Rob Herring (Arm)
2024-05-31  1:03 ` [PATCH 2/3] of: Add missing locking to of_(bus_)?n_(size|addr)_cells() Rob Herring (Arm)
2024-06-04 16:08   ` Rob Herring
2024-05-31  1:03 ` [PATCH 3/3] of/irq: Use of_bus_n_addr_cells() to retrieve "#address-cells" Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240530-dt-interrupt-map-fix-v1-0-2331d8732f08@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®