From: Kory Maincent <kory.maincent@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Dent Project <dentproject@linuxfoundation.org>,
kernel@pengutronix.de
Subject: Re: [PATCH 4/8] net: pse-pd: pd692x0: Expand ethtool status message
Date: Thu, 30 May 2024 11:33:41 +0200 [thread overview]
Message-ID: <20240530113341.36865f09@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <d6aab44f-5e9a-4281-8c67-4b890b726337@lunn.ch>
Thanks for the review!
On Thu, 30 May 2024 01:13:59 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> > +static const struct pd692x0_status_msg pd692x0_status_msg_list[] = {
> > + {.id = 0x06, .msg = "Port is off: Main supply voltage is high."},
> > + {.id = 0x07, .msg = "Port is off: Main supply voltage is low."},
> > + {.id = 0x08, .msg = "Port is off: Disable all ports pin is
> > active."},
> > + {.id = 0x0C, .msg = "Port is off: Non-existing port number."},
> > + {.id = 0x11, .msg = "Port is yet undefined."},
> > + {.id = 0x12, .msg = "Port is off: Internal hardware fault."},
> > + {.id = 0x1A, .msg = "Port is off: User setting."},
> > + {.id = 0x1B, .msg = "Port is off: Detection is in process."},
> > + {.id = 0x1C, .msg = "Port is off: Non-802.3AF/AT powered device."},
> > + {.id = 0x1E, .msg = "Port is off: Underload state."},
> > + {.id = 0x1F, .msg = "Port is off: Overload state."},
> > + {.id = 0x20, .msg = "Port is off: Power budget exceeded."},
> > + {.id = 0x21, .msg = "Port is off: Internal hardware routing
> > error."},
> > + {.id = 0x22, .msg = "Port is off: Configuration change."},
> > + {.id = 0x24, .msg = "Port is off: Voltage injection into the
> > port."},
> > + {.id = 0x25, .msg = "Port is off: Improper Capacitor Detection"},
> > + {.id = 0x26, .msg = "Port is off: Discharged load."},
>
> I don't know of any other driver returning strings like this. Have you
> seen any other PSE driver with anything similar?
We would like to be able to return the failure reason but there is nothing
generic in the IEEE 802.3 standard to be able to add it to the UAPI.
The TI controller has SUPPLY and FAULT EVENT Register which could report few
messages. I am not aware of other PoE controller and how they deal with it.
We could add sysfs for reporting the status messages for all the ports but I
don't think it is a better idea.
> > + {.id = 0x34, .msg = "Port is off: Short condition."},
> > + {.id = 0x35, .msg = "Port is off: Over temperature at the port."},
> > + {.id = 0x36, .msg = "Port is off: Device is too hot."},
> > + {.id = 0x37, .msg = "Unknown device port status."},
> > + {.id = 0x3C, .msg = "Power Management-Static."},
> > + {.id = 0x3D, .msg = "Power Management-Static\u2014OVL."},
>
> Is there something going on with UTF here? the \u2014 ?
Some copy paste of the messages bring a non utf-8 character :/
Will fix it, thanks for spotting it.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-05-30 9:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 14:09 [PATCH 0/8] net: pse-pd: Add new PSE c33 features Kory Maincent
2024-05-29 14:09 ` [PATCH 1/8] net: pse-pd: Use EOPNOTSUPP error code instead of ENOTSUPP Kory Maincent
2024-05-29 23:02 ` Andrew Lunn
2024-05-29 14:09 ` [PATCH 2/8] net: ethtool: pse-pd: Expand C33 PSE status with class, power and status message Kory Maincent
2024-05-30 10:32 ` Donald Hunter
2024-05-30 12:58 ` Kory Maincent
2024-05-29 14:09 ` [PATCH 3/8] netlink: specs: Expand the PSE netlink command with C33 new features Kory Maincent
2024-05-30 10:31 ` Donald Hunter
2024-05-29 14:09 ` [PATCH 4/8] net: pse-pd: pd692x0: Expand ethtool status message Kory Maincent
2024-05-29 23:13 ` Andrew Lunn
2024-05-30 9:33 ` Kory Maincent [this message]
2024-05-30 10:13 ` Oleksij Rempel
2024-05-29 14:09 ` [PATCH 5/8] net: pse-pd: Add new power limit get and set c33 features Kory Maincent
2024-05-29 14:09 ` [PATCH 6/8] net: ethtool: Add new power limit get and set features Kory Maincent
2024-05-29 14:09 ` [PATCH 7/8] netlink: specs: Expand the PSE netlink command with C33 pw-limit attributes Kory Maincent
2024-05-29 14:09 ` [PATCH 8/8] net: pse-pd: pd692x0: Enhance with new current limit and voltage read callbacks Kory Maincent
2024-05-29 14:13 ` [PATCH 0/8] net: pse-pd: Add new PSE c33 features Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530113341.36865f09@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®