mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: "Steven Rostedt (Google)" <rostedt@goodmis.org>,
	<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] fprobe: add missing MODULE_DESCRIPTION() macro
Date: Sun, 2 Jun 2024 10:06:53 +0900	[thread overview]
Message-ID: <20240602100653.b73ac42fd9a010cece98ec01@kernel.org> (raw)
In-Reply-To: <20240601-md-samples-fprobe-v1-1-5d256a956612@quicinc.com>

On Sat, 1 Jun 2024 17:25:22 -0700
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:

> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/fprobe/fprobe_example.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 

Thanks for adding this. Looks good to me.

Let me pick it to probes/for-next.


> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  samples/fprobe/fprobe_example.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/samples/fprobe/fprobe_example.c b/samples/fprobe/fprobe_example.c
> index 64e715e7ed11..0a50b05add96 100644
> --- a/samples/fprobe/fprobe_example.c
> +++ b/samples/fprobe/fprobe_example.c
> @@ -150,4 +150,5 @@ static void __exit fprobe_exit(void)
>  
>  module_init(fprobe_init)
>  module_exit(fprobe_exit)
> +MODULE_DESCRIPTION("sample kernel module showing the use of fprobe");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> change-id: 20240601-md-samples-fprobe-b2b92d8be350
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

      reply	other threads:[~2024-06-02  1:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02  0:25 Jeff Johnson
2024-06-02  1:06 ` Masami Hiramatsu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240602100653.b73ac42fd9a010cece98ec01@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®