mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Vasileios Amoiridis <vassilisamir@gmail.com>,
	lars@metafoo.de, himanshujha199640@gmail.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 05/17] iio: chemical: bme680: Fix type in define
Date: Sun, 2 Jun 2024 21:17:18 +0200	[thread overview]
Message-ID: <20240602191718.GB387181@vamoiridPC> (raw)
In-Reply-To: <20240602134150.6cdf01af@jic23-huawei>

On Sun, Jun 02, 2024 at 01:41:50PM +0100, Jonathan Cameron wrote:
> On Mon, 27 May 2024 20:37:53 +0200
> Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> Patch title "type" should be "typo". :)
> 

Ah, you are right thanks for pointing this out!

Cheers,
Vasilis

> > Fix a define typo that instead of BME680_... it is
> > saying BM6880_...
> > 
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> >  drivers/iio/chemical/bme680.h      | 2 +-
> >  drivers/iio/chemical/bme680_core.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/chemical/bme680.h b/drivers/iio/chemical/bme680.h
> > index 4edc5d21cb9f..3133d624270a 100644
> > --- a/drivers/iio/chemical/bme680.h
> > +++ b/drivers/iio/chemical/bme680.h
> > @@ -12,7 +12,7 @@
> >  
> >  #define BME680_REG_TEMP_MSB			0x22
> >  #define BME680_REG_PRESS_MSB			0x1F
> > -#define BM6880_REG_HUMIDITY_MSB			0x25
> > +#define BME680_REG_HUMIDITY_MSB			0x25
> >  #define BME680_REG_GAS_MSB			0x2A
> >  #define BME680_REG_GAS_R_LSB			0x2B
> >  #define   BME680_GAS_STAB_BIT			BIT(4)
> > diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
> > index dd2cd11b6dd3..8b42c4716412 100644
> > --- a/drivers/iio/chemical/bme680_core.c
> > +++ b/drivers/iio/chemical/bme680_core.c
> > @@ -719,7 +719,7 @@ static int bme680_read_humid(struct bme680_data *data,
> >  	if (ret < 0)
> >  		return ret;
> >  
> > -	ret = regmap_bulk_read(data->regmap, BM6880_REG_HUMIDITY_MSB,
> > +	ret = regmap_bulk_read(data->regmap, BME680_REG_HUMIDITY_MSB,
> >  			       &tmp, sizeof(tmp));
> >  	if (ret < 0) {
> >  		dev_err(dev, "failed to read humidity\n");
> 

  reply	other threads:[~2024-06-02 19:17 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 18:37 [PATCH v1 00/17] iio: chemical: bme680: Driver cleanup Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 01/17] iio: chemical: bme680: Fix pressure value output Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 02/17] iio: chemical: bme680: Fix calibration data variable Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 03/17] iio: chemical: bme680: Fix overflows in compensate() functions Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 04/17] iio: chemical: bme680: Fix sensor data read operation Vasileios Amoiridis
2024-06-02 12:41   ` Jonathan Cameron
2024-06-02 19:00     ` Vasileios Amoiridis
2024-06-03 19:23       ` Jonathan Cameron
2024-06-03 20:31         ` Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 05/17] iio: chemical: bme680: Fix type in define Vasileios Amoiridis
2024-06-02 12:41   ` Jonathan Cameron
2024-06-02 19:17     ` Vasileios Amoiridis [this message]
2024-05-27 18:37 ` [PATCH v1 06/17] iio: chemical: bme680: Add mutexes to guard read/write to device Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 07/17] iio: chemical: bme680: Drop unnecessary casts and correct adc data types Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 08/17] iio: chemical: bme680: Remove remaining ACPI-only stuff Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 09/17] iio: chemical: bme680: Sort headers alphabetically Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 10/17] iio: chemical: bme680: Remove duplicate register read Vasileios Amoiridis
2024-06-02 12:50   ` Jonathan Cameron
2024-06-02 19:25     ` Vasileios Amoiridis
2024-05-27 18:37 ` [PATCH v1 11/17] iio: chemical: bme680: Use bulk reads for calibration data Vasileios Amoiridis
2024-06-02 12:57   ` Jonathan Cameron
2024-06-02 19:30     ` Vasileios Amoiridis
2024-06-03 19:25       ` Jonathan Cameron
2024-06-03 20:30         ` Vasileios Amoiridis
2024-06-06 19:36           ` Jonathan Cameron
2024-05-27 18:38 ` [PATCH v1 12/17] iio: chemical: bme680: Allocate IIO device before chip initialization Vasileios Amoiridis
2024-05-27 18:38 ` [PATCH v1 13/17] iio: chemical: bme680: Add read buffers in DMA safe region Vasileios Amoiridis
2024-06-02 12:59   ` Jonathan Cameron
2024-06-02 19:33     ` Vasileios Amoiridis
2024-06-03 19:27       ` Jonathan Cameron
2024-05-27 18:38 ` [PATCH v1 14/17] iio: chemical: bme680: Modify startup procedure Vasileios Amoiridis
2024-06-02 13:01   ` Jonathan Cameron
2024-06-02 19:40     ` Vasileios Amoiridis
2024-05-27 18:38 ` [PATCH v1 15/17] iio: chemical: bme680: Remove redundant gas configuration Vasileios Amoiridis
2024-05-27 18:38 ` [PATCH v1 16/17] iio: chemical: bme680: Move forced mode setup in ->read_raw() Vasileios Amoiridis
2024-05-27 18:38 ` [PATCH v1 17/17] iio: chemical: bme680: Refactorize reading functions Vasileios Amoiridis
2024-06-02 13:04   ` Jonathan Cameron
2024-06-02 19:53     ` Vasileios Amoiridis
2024-06-02 12:31 ` [PATCH v1 00/17] iio: chemical: bme680: Driver cleanup Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240602191718.GB387181@vamoiridPC \
    --to=vassilisamir@gmail.com \
    --cc=himanshujha199640@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®