From: Beata Michalska <beata.michalska@arm.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ionela.voinescu@arm.com,
sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com,
vincent.guittot@linaro.org, vanshikonda@os.amperecomputing.com
Cc: sumitg@nvidia.com, yang@os.amperecomputing.com,
lihuisong@huawei.com, viresh.kumar@linaro.org, rafael@kernel.org
Subject: [PATCH v6 1/4] arch_topology: init capacity_freq_ref to 0
Date: Mon, 3 Jun 2024 09:21:51 +0100 [thread overview]
Message-ID: <20240603082154.3830591-2-beata.michalska@arm.com> (raw)
In-Reply-To: <20240603082154.3830591-1-beata.michalska@arm.com>
From: Ionela Voinescu <ionela.voinescu@arm.com>
It's useful to have capacity_freq_ref initialized to 0 for users of
arch_scale_freq_ref() to detect when capacity_freq_ref was not
yet set.
The only scenario affected by this change in the init value is when a
cpufreq driver is never loaded. As a result, the only setter of a
cpu scale factor remains the call of topology_normalize_cpu_scale()
from parse_dt_topology(). There we cannot use the value 0 of
capacity_freq_ref so we have to compensate for its uninitialized state.
Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
Signed-off-by: Beata Michalska <beata.michalska@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/base/arch_topology.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index c66d070207a0..b8217ce9082c 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -27,7 +27,7 @@
static DEFINE_PER_CPU(struct scale_freq_data __rcu *, sft_data);
static struct cpumask scale_freq_counters_mask;
static bool scale_freq_invariant;
-DEFINE_PER_CPU(unsigned long, capacity_freq_ref) = 1;
+DEFINE_PER_CPU(unsigned long, capacity_freq_ref) = 0;
EXPORT_PER_CPU_SYMBOL_GPL(capacity_freq_ref);
static bool supports_scale_freq_counters(const struct cpumask *cpus)
@@ -292,13 +292,15 @@ void topology_normalize_cpu_scale(void)
capacity_scale = 1;
for_each_possible_cpu(cpu) {
- capacity = raw_capacity[cpu] * per_cpu(capacity_freq_ref, cpu);
+ capacity = raw_capacity[cpu] *
+ (per_cpu(capacity_freq_ref, cpu) ?: 1);
capacity_scale = max(capacity, capacity_scale);
}
pr_debug("cpu_capacity: capacity_scale=%llu\n", capacity_scale);
for_each_possible_cpu(cpu) {
- capacity = raw_capacity[cpu] * per_cpu(capacity_freq_ref, cpu);
+ capacity = raw_capacity[cpu] *
+ (per_cpu(capacity_freq_ref, cpu) ?: 1);
capacity = div64_u64(capacity << SCHED_CAPACITY_SHIFT,
capacity_scale);
topology_set_cpu_scale(cpu, capacity);
--
2.25.1
next prev parent reply other threads:[~2024-06-03 8:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 8:21 [PATCH v6 0/4] Add support for AArch64 AMUv1-based arch_freq_get_on_cpu Beata Michalska
2024-06-03 8:21 ` Beata Michalska [this message]
2024-06-03 8:21 ` [PATCH v6 2/4] arm64: amu: Delay allocating cpumask for AMU FIE support Beata Michalska
2024-06-03 8:21 ` [PATCH v6 3/4] arm64: Provide an AMU-based version of arch_freq_get_on_cpu Beata Michalska
2024-07-10 17:44 ` Vanshidhar Konda
2024-07-17 6:54 ` Beata Michalska
2024-08-14 6:46 ` Jie Zhan
2024-08-26 7:23 ` Beata Michalska
2024-08-27 13:05 ` Jie Zhan
2024-06-03 8:21 ` [PATCH v6 4/4] arm64: Update AMU-based freq scale factor on entering idle Beata Michalska
2024-07-08 17:10 ` [PATCH v6 0/4] Add support for AArch64 AMUv1-based arch_freq_get_on_cpu Catalin Marinas
2024-07-11 13:59 ` Beata Michalska
2024-08-14 8:05 ` Jie Zhan
2024-08-26 7:24 ` Beata Michalska
2024-08-27 13:03 ` Jie Zhan
[not found] ` <8a9b4e02-a5c6-cb1b-fd32-728fc2c5e741@hisilicon.com>
2024-09-06 9:45 ` Beata Michalska
2024-07-14 0:32 ` Vanshidhar Konda
2024-07-17 6:58 ` Beata Michalska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603082154.3830591-2-beata.michalska@arm.com \
--to=beata.michalska@arm.com \
--cc=catalin.marinas@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=lihuisong@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=sumitg@nvidia.com \
--cc=vanshikonda@os.amperecomputing.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®