mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] readdir: Remove unused header include
Date: Mon, 3 Jun 2024 13:06:52 +0200	[thread overview]
Message-ID: <20240603110652.5hjcsajjjmefv63i@quack3> (raw)
In-Reply-To: <20240602101534.348159-2-thorsten.blum@toblux.com>

On Sun 02-06-24 12:15:35, Thorsten Blum wrote:
> Since commit c512c6918719 ("uaccess: implement a proper
> unsafe_copy_to_user() and switch filldir over to it") the header file is
> no longer needed.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Nice. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/readdir.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/readdir.c b/fs/readdir.c
> index 5045e32f1cb6..d6c82421902a 100644
> --- a/fs/readdir.c
> +++ b/fs/readdir.c
> @@ -22,8 +22,6 @@
>  #include <linux/compat.h>
>  #include <linux/uaccess.h>
>  
> -#include <asm/unaligned.h>
> -
>  /*
>   * Some filesystems were never converted to '->iterate_shared()'
>   * and their directory iterators want the inode lock held for
> -- 
> 2.45.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2024-06-03 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02 10:15 Thorsten Blum
2024-06-03 11:06 ` Jan Kara [this message]
2024-06-03 13:48 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240603110652.5hjcsajjjmefv63i@quack3 \
    --to=jack@suse.cz \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thorsten.blum@toblux.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®