From: Yu Kuai <yukuai3@huawei.com>
To: <agk@redhat.com>, <snitzer@kernel.org>, <mpatocka@redhat.com>,
<song@kernel.org>, <xni@redhat.com>,
<mariusz.tkaczyk@linux.intel.com>, <l@damenly.org>
Cc: <dm-devel@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-raid@vger.kernel.org>, <yukuai3@huawei.com>,
<yukuai1@huaweicloud.com>, <yi.zhang@huawei.com>,
<yangerkun@huawei.com>
Subject: [PATCH 01/12] md: rearrange recovery_flags
Date: Mon, 3 Jun 2024 20:58:04 +0800 [thread overview]
Message-ID: <20240603125815.2199072-2-yukuai3@huawei.com> (raw)
In-Reply-To: <20240603125815.2199072-1-yukuai3@huawei.com>
Currently there are lots of flags with the same confusing prefix
"MD_REOCVERY_", and there are two main types of flags, sync thread runnng
status, I prefer prefix "SYNC_THREAD_", and sync thread action, I perfer
prefix "SYNC_ACTION_".
For now, rearrange and update comment to improve code readability,
there are no functional changes.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/md/md.h | 52 ++++++++++++++++++++++++++++++++++++-------------
1 file changed, 38 insertions(+), 14 deletions(-)
diff --git a/drivers/md/md.h b/drivers/md/md.h
index ca085ecad504..170412a65b63 100644
--- a/drivers/md/md.h
+++ b/drivers/md/md.h
@@ -551,22 +551,46 @@ struct mddev {
};
enum recovery_flags {
+ /* flags for sync thread running status */
+
+ /*
+ * set when one of sync action is set and new sync thread need to be
+ * registered, or just add/remove spares from conf.
+ */
+ MD_RECOVERY_NEEDED,
+ /* sync thread is running, or about to be started */
+ MD_RECOVERY_RUNNING,
+ /* sync thread needs to be aborted for some reason */
+ MD_RECOVERY_INTR,
+ /* sync thread is done and is waiting to be unregistered */
+ MD_RECOVERY_DONE,
+ /* running sync thread must abort immediately, and not restart */
+ MD_RECOVERY_FROZEN,
+ /* waiting for pers->start() to finish */
+ MD_RECOVERY_WAIT,
+ /* interrupted because io-error */
+ MD_RECOVERY_ERROR,
+
+ /* flags determines sync action */
+
+ /* if just this flag is set, action is resync. */
+ MD_RECOVERY_SYNC,
+ /*
+ * paired with MD_RECOVERY_SYNC, if MD_RECOVERY_CHECK is not set,
+ * action is repair, means user requested resync.
+ */
+ MD_RECOVERY_REQUESTED,
/*
- * If neither SYNC or RESHAPE are set, then it is a recovery.
+ * paired with MD_RECOVERY_SYNC and MD_RECOVERY_REQUESTED, action is
+ * check.
*/
- MD_RECOVERY_RUNNING, /* a thread is running, or about to be started */
- MD_RECOVERY_SYNC, /* actually doing a resync, not a recovery */
- MD_RECOVERY_RECOVER, /* doing recovery, or need to try it. */
- MD_RECOVERY_INTR, /* resync needs to be aborted for some reason */
- MD_RECOVERY_DONE, /* thread is done and is waiting to be reaped */
- MD_RECOVERY_NEEDED, /* we might need to start a resync/recover */
- MD_RECOVERY_REQUESTED, /* user-space has requested a sync (used with SYNC) */
- MD_RECOVERY_CHECK, /* user-space request for check-only, no repair */
- MD_RECOVERY_RESHAPE, /* A reshape is happening */
- MD_RECOVERY_FROZEN, /* User request to abort, and not restart, any action */
- MD_RECOVERY_ERROR, /* sync-action interrupted because io-error */
- MD_RECOVERY_WAIT, /* waiting for pers->start() to finish */
- MD_RESYNCING_REMOTE, /* remote node is running resync thread */
+ MD_RECOVERY_CHECK,
+ /* recovery, or need to try it */
+ MD_RECOVERY_RECOVER,
+ /* reshape */
+ MD_RECOVERY_RESHAPE,
+ /* remote node is running resync thread */
+ MD_RESYNCING_REMOTE,
};
enum md_ro_state {
--
2.39.2
next prev parent reply other threads:[~2024-06-03 12:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 12:58 [PATCH 00/12] md: refacotor and some fixes related to sync_thread Yu Kuai
2024-06-03 12:58 ` Yu Kuai [this message]
2024-06-03 12:58 ` [PATCH 02/12] md: add a new enum type sync_action Yu Kuai
2024-06-11 8:31 ` Mariusz Tkaczyk
2024-06-11 13:30 ` Yu Kuai
2024-06-03 12:58 ` [PATCH 03/12] md: add new helpers for sync_action Yu Kuai
2024-06-03 12:58 ` [PATCH 04/12] md: factor out helper to start reshape from action_store() Yu Kuai
2024-06-03 12:58 ` [PATCH 05/12] md: replace sysfs api sync_action with new helpers Yu Kuai
2024-06-03 12:58 ` [PATCH 06/12] md: remove parameter check_seq for stop_sync_thread() Yu Kuai
2024-06-03 12:58 ` [PATCH 07/12] md: don't fail action_store() if sync_thread is not registered Yu Kuai
2024-06-03 12:58 ` [PATCH 08/12] md: use new helers in md_do_sync() Yu Kuai
2024-06-03 12:58 ` [PATCH 09/12] md: replace last_sync_action with new enum type Yu Kuai
2024-06-03 12:58 ` [PATCH 10/12] md: factor out helpers for different sync_action in md_do_sync() Yu Kuai
2024-06-03 12:58 ` [PATCH 11/12] md: pass in max_sectors for pers->sync_request() Yu Kuai
2024-06-03 12:58 ` [PATCH 12/12] md/raid5: avoid BUG_ON() while continue reshape after reassembling Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603125815.2199072-2-yukuai3@huawei.com \
--to=yukuai3@huawei.com \
--cc=agk@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=l@damenly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mariusz.tkaczyk@linux.intel.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®