From: Beleswar Padhi <b-padhi@ti.com>
To: <andersson@kernel.org>, <mathieu.poirier@linaro.org>
Cc: <hnagalla@ti.com>, <u-kumar1@ti.com>, <afd@ti.com>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 0/3] Defer TI's Remoteproc's Probe until Mailbox is Probed
Date: Tue, 4 Jun 2024 10:47:19 +0530 [thread overview]
Message-ID: <20240604051722.3608750-1-b-padhi@ti.com> (raw)
Hello All,
This series adds deferred probe functionality in the TI's Remoteproc
drivers. The remoteproc drivers are dependent on the omap-mailbox driver
for mbox functionalities. Sometimes, the remoteproc driver could be
probed before the mailbox driver leading to rproc boot failures. Thus,
defer the probe routine of remoteproc drivers until mailbox driver is
probed by checking the mbox_request_channel handle in probe.
Also, use the acquired mbox handle in probe during rproc start/attach
routine instead of re-requesting. Do not free mbox handle during
stop/detach routine or error paths. This makes our k3_rproc_attach() &
k3_rproc_detach() functions NOP.
Also, use the devm_rproc_alloc() helper to automatically free created
rprocs incase of a probe defer.
v2: Changelog:
1) Added a check in k3_mbox_callback() to prevent forwarding messages to
a detached core.
2) Addressed Andrew's comments in v1 regarding some cleanup (Using
dev_err_probe, removing unused labels, adding matching mbox_free_channel
call during device removal).
Link to v1:
https://lore.kernel.org/all/20240530090737.655054-1-b-padhi@ti.com/
Beleswar Padhi (3):
remoteproc: k3-r5: Use devm_rproc_alloc() helper
remoteproc: k3-r5: Acquire mailbox handle during probe
remoteproc: k3-dsp: Acquire mailbox handle during probe routine
drivers/remoteproc/ti_k3_dsp_remoteproc.c | 76 ++++++++-------------
drivers/remoteproc/ti_k3_r5_remoteproc.c | 80 ++++++++---------------
2 files changed, 54 insertions(+), 102 deletions(-)
--
2.34.1
next reply other threads:[~2024-06-04 5:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 5:17 Beleswar Padhi [this message]
2024-06-04 5:17 ` [PATCH v2 1/3] remoteproc: k3-r5: Use devm_rproc_alloc() helper Beleswar Padhi
2024-06-04 5:17 ` [PATCH v2 2/3] remoteproc: k3-r5: Acquire mailbox handle during probe Beleswar Padhi
2024-06-04 17:10 ` Andrew Davis
2024-06-05 10:58 ` Beleswar Prasad Padhi
2024-06-21 11:14 ` Beleswar Prasad Padhi
2024-06-21 13:46 ` Andrew Davis
2024-06-04 5:17 ` [PATCH v2 3/3] remoteproc: k3-dsp: Acquire mailbox handle during probe routine Beleswar Padhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604051722.3608750-1-b-padhi@ti.com \
--to=b-padhi@ti.com \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=hnagalla@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®