From: "Paul E. McKenney" <paulmck@kernel.org>
To: linux-arch@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
elver@google.com, akpm@linux-foundation.org, tglx@linutronix.de,
peterz@infradead.org, dianders@chromium.org, pmladek@suse.com,
torvalds@linux-foundation.org, arnd@arndb.de,
"Paul E. McKenney" <paulmck@kernel.org>,
Mark Brown <broonie@kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Nathan Chancellor <nathan@kernel.org>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Andrew Davis <afd@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Eric DeVolder <eric.devolder@oracle.com>,
Rob Herring <robh@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 cmpxchg 4/4] ARM: Emulate one-byte cmpxchg
Date: Tue, 4 Jun 2024 10:04:37 -0700 [thread overview]
Message-ID: <20240604170437.2362545-4-paulmck@kernel.org> (raw)
In-Reply-To: <1dee481f-d584-41d6-a5f1-d84375be5fe8@paulmck-laptop>
Use the new cmpxchg_emu_u8() to emulate one-byte cmpxchg() on ARM systems
with ARCH < ARMv6K.
[ paulmck: Apply Arnd Bergmann and Nathan Chancellor feedback. ]
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/54798f68-48f7-4c65-9cba-47c0bf175143@sirena.org.uk/
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Closes: https://lore.kernel.org/all/CA+G9fYuZ+pf6p8AXMZWtdFtX-gbG8HMaBKp=XbxcdzA_QeLkxQ@mail.gmail.com/
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Cc: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Davis <afd@ti.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Eric DeVolder <eric.devolder@oracle.com>
Cc: Rob Herring <robh@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>
---
arch/arm/Kconfig | 1 +
arch/arm/include/asm/cmpxchg.h | 7 ++++++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index ee5115252aac4..a867a7d967aa5 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -34,6 +34,7 @@ config ARM
select ARCH_MIGHT_HAVE_PC_PARPORT
select ARCH_OPTIONAL_KERNEL_RWX if ARCH_HAS_STRICT_KERNEL_RWX
select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT if CPU_V7
+ select ARCH_NEED_CMPXCHG_1_EMU if CPU_V6
select ARCH_SUPPORTS_ATOMIC_RMW
select ARCH_SUPPORTS_CFI_CLANG
select ARCH_SUPPORTS_HUGETLBFS if ARM_LPAE
diff --git a/arch/arm/include/asm/cmpxchg.h b/arch/arm/include/asm/cmpxchg.h
index 44667bdb4707a..a428e06fe94ee 100644
--- a/arch/arm/include/asm/cmpxchg.h
+++ b/arch/arm/include/asm/cmpxchg.h
@@ -5,6 +5,7 @@
#include <linux/irqflags.h>
#include <linux/prefetch.h>
#include <asm/barrier.h>
+#include <linux/cmpxchg-emu.h>
#if defined(CONFIG_CPU_SA1100) || defined(CONFIG_CPU_SA110)
/*
@@ -162,7 +163,11 @@ static inline unsigned long __cmpxchg(volatile void *ptr, unsigned long old,
prefetchw((const void *)ptr);
switch (size) {
-#ifndef CONFIG_CPU_V6 /* min ARCH >= ARMv6K */
+#ifdef CONFIG_CPU_V6 /* min ARCH < ARMv6K */
+ case 1:
+ oldval = cmpxchg_emu_u8((volatile u8 *)ptr, old, new);
+ break;
+#else /* min ARCH >= ARMv6K */
case 1:
do {
asm volatile("@ __cmpxchg1\n"
--
2.40.1
next prev parent reply other threads:[~2024-06-04 17:04 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 21:39 [PATCH RFC cmpxchg 0/8] Provide emulation for one- and two-byte cmpxchg() Paul E. McKenney
2024-04-01 21:39 ` [PATCH RFC cmpxchg 1/8] lib: Add one-byte and two-byte cmpxchg() emulation functions Paul E. McKenney
2024-04-02 13:07 ` Marco Elver
2024-04-02 17:15 ` Paul E. McKenney
2024-04-01 21:39 ` [PATCH RFC cmpxchg 2/8] sparc: Emulate one-byte and two-byte cmpxchg Paul E. McKenney
2024-04-01 22:38 ` Al Viro
2024-04-01 23:58 ` Paul E. McKenney
2024-04-02 0:07 ` Al Viro
2024-04-02 3:37 ` Al Viro
2024-04-02 4:11 ` Al Viro
2024-04-02 4:18 ` Paul E. McKenney
2024-04-02 4:28 ` [PATCH 1/8] sparc32: make __cmpxchg_u32() return u32 Al Viro
2024-04-02 4:28 ` [PATCH 2/8] sparc32: make the first argument of __cmpxchg_u64() volatile u64 * Al Viro
2024-04-02 4:28 ` [PATCH 3/8] sparc32: unify __cmpxchg_u{32,64} Al Viro
2024-04-02 7:28 ` Arnd Bergmann
2024-04-02 20:02 ` Paul E. McKenney
2024-04-02 4:28 ` [PATCH 4/8] sparc32: add __cmpxchg_u{8,16}() and teach __cmpxchg() to handle those sizes Al Viro
2024-04-02 4:28 ` [PATCH 5/8] parisc: __cmpxchg_u32(): lift conversion into the callers Al Viro
2024-04-02 4:28 ` [PATCH 6/8] parisc: unify implementations of __cmpxchg_u{8,32,64} Al Viro
2024-04-02 4:28 ` [PATCH 7/8] parisc: add missing export of __cmpxchg_u8() Al Viro
2024-04-02 4:28 ` [PATCH 8/8] parisc: add u16 support to cmpxchg() Al Viro
2024-04-02 20:03 ` [PATCH 1/8] sparc32: make __cmpxchg_u32() return u32 Paul E. McKenney
2024-04-03 22:20 ` Al Viro
2024-04-04 3:09 ` Paul E. McKenney
2024-04-02 4:17 ` [PATCH RFC cmpxchg 2/8] sparc: Emulate one-byte and two-byte cmpxchg Paul E. McKenney
2024-04-01 21:39 ` [PATCH RFC cmpxchg 3/8] ARC: " Paul E. McKenney
2024-04-02 8:14 ` Arnd Bergmann
2024-04-02 17:06 ` Paul E. McKenney
2024-04-02 20:52 ` Paul E. McKenney
2024-04-04 11:57 ` Arnd Bergmann
2024-04-04 14:44 ` Paul E. McKenney
2024-04-04 15:06 ` Arnd Bergmann
2024-04-01 21:39 ` [PATCH RFC cmpxchg 4/8] csky: " Paul E. McKenney
2024-04-01 21:39 ` [PATCH RFC cmpxchg 5/8] sh: " Paul E. McKenney
2024-04-01 21:39 ` [PATCH RFC cmpxchg 6/8] xtensa: " Paul E. McKenney
2024-04-01 21:39 ` [PATCH RFC cmpxchg 7/8] parisc: Emulate " Paul E. McKenney
2024-04-01 21:39 ` [PATCH RFC cmpxchg 8/8] riscv: Emulate one-byte and " Paul E. McKenney
2024-04-04 14:15 ` Palmer Dabbelt
2024-04-04 14:50 ` Paul E. McKenney
2024-05-11 6:50 ` Guo Ren
2024-05-11 14:54 ` Paul E. McKenney
2024-05-11 20:44 ` Leonardo Bras
2024-04-08 17:47 ` [PATCH RFC cmpxchg 0/8] Provide emulation for one- and two-byte cmpxchg() Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 01/14] sparc32: make __cmpxchg_u32() return u32 Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 02/14] sparc32: make the first argument of __cmpxchg_u64() volatile u64 * Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 03/14] sparc32: unify __cmpxchg_u{32,64} Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 04/14] sparc32: add __cmpxchg_u{8,16}() and teach __cmpxchg() to handle those sizes Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 05/14] parisc: __cmpxchg_u32(): lift conversion into the callers Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 06/14] parisc: unify implementations of __cmpxchg_u{8,32,64} Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 07/14] parisc: add missing export of __cmpxchg_u8() Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 08/14] parisc: add u16 support to cmpxchg() Paul E. McKenney
2024-04-08 20:10 ` Linus Torvalds
2024-04-08 20:53 ` Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 09/14] lib: Add one-byte emulation function Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 10/14] ARC: Emulate one-byte cmpxchg Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 11/14] csky: " Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 12/14] sh: " Paul E. McKenney
2024-04-18 8:04 ` Geert Uytterhoeven
2024-04-08 17:49 ` [PATCH cmpxchg 13/14] xtensa: " Paul E. McKenney
2024-04-18 8:06 ` Geert Uytterhoeven
2024-04-18 23:21 ` Paul E. McKenney
2024-04-19 5:07 ` Yujie Liu
2024-04-19 8:02 ` Geert Uytterhoeven
2024-04-20 14:03 ` Paul E. McKenney
2024-04-08 17:49 ` [PATCH cmpxchg 14/14] riscv: " Paul E. McKenney
2024-04-09 17:35 ` Andrea Parri
2024-04-09 18:08 ` Paul E. McKenney
2024-05-01 22:58 ` [PATCH v2 cmpxchg 0/8] Provide emulation for one--byte cmpxchg() Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 01/13] sparc32: make __cmpxchg_u32() return u32 Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 02/13] sparc32: make the first argument of __cmpxchg_u64() volatile u64 * Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 03/13] sparc32: unify __cmpxchg_u{32,64} Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 04/13] sparc32: add __cmpxchg_u{8,16}() and teach __cmpxchg() to handle those sizes Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 05/13] parisc: __cmpxchg_u32(): lift conversion into the callers Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 06/13] parisc: unify implementations of __cmpxchg_u{8,32,64} Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 07/13] parisc: add missing export of __cmpxchg_u8() Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 08/13] parisc: add u16 support to cmpxchg() Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 09/13] lib: Add one-byte emulation function Paul E. McKenney
2024-05-13 14:44 ` Boqun Feng
2024-05-13 15:41 ` Paul E. McKenney
2024-05-13 15:57 ` Boqun Feng
2024-05-13 21:19 ` Boqun Feng
2024-05-14 14:22 ` Paul E. McKenney
2024-05-14 14:53 ` Boqun Feng
2024-05-14 15:02 ` Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 10/13] ARC: Emulate one-byte cmpxchg Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 11/13] csky: " Paul E. McKenney
2024-05-11 6:42 ` Guo Ren
2024-05-11 14:49 ` Paul E. McKenney
2024-05-01 23:01 ` [PATCH v2 cmpxchg 12/13] sh: " Paul E. McKenney
2024-05-02 4:52 ` John Paul Adrian Glaubitz
2024-05-02 5:06 ` Paul E. McKenney
2024-05-02 5:11 ` John Paul Adrian Glaubitz
2024-05-02 13:33 ` Paul E. McKenney
2024-05-02 20:53 ` Al Viro
2024-05-02 21:01 ` alpha cmpxchg.h (was Re: [PATCH v2 cmpxchg 12/13] sh: Emulate one-byte cmpxchg) Al Viro
2024-05-02 22:16 ` Linus Torvalds
2024-05-02 21:18 ` [PATCH v2 cmpxchg 12/13] sh: Emulate one-byte cmpxchg Paul E. McKenney
2024-05-02 22:07 ` Al Viro
2024-05-02 23:12 ` Paul E. McKenney
2024-05-02 23:24 ` Al Viro
2024-05-02 23:45 ` Paul E. McKenney
2024-05-02 23:32 ` Linus Torvalds
2024-05-03 0:16 ` Paul E. McKenney
2024-05-02 21:50 ` Arnd Bergmann
2024-05-02 5:42 ` D. Jeff Dionne
2024-05-02 11:30 ` Arnd Bergmann
2024-05-01 23:01 ` [PATCH v2 cmpxchg 13/13] xtensa: " Paul E. McKenney
2024-05-02 20:01 ` [PATCH v2 cmpxchg 0/8] Provide emulation for one--byte cmpxchg() Al Viro
2024-05-02 21:20 ` Paul E. McKenney
2024-06-04 17:02 ` [PATCH v3 cmpxchg 0/4] " Paul E. McKenney
2024-06-04 17:04 ` [PATCH v3 cmpxchg 1/4] ARC: Emulate one-byte cmpxchg Paul E. McKenney
2024-06-04 17:04 ` [PATCH v3 cmpxchg 2/4] sh: " Paul E. McKenney
2024-06-04 17:09 ` John Paul Adrian Glaubitz
2024-06-04 17:50 ` Paul E. McKenney
2024-06-04 17:56 ` John Paul Adrian Glaubitz
2024-06-04 21:14 ` Paul E. McKenney
2024-06-17 16:50 ` Paul E. McKenney
2024-06-17 20:30 ` John Paul Adrian Glaubitz
2024-06-17 21:59 ` Paul E. McKenney
2024-06-04 17:04 ` [PATCH v3 cmpxchg 3/4] xtensa: " Paul E. McKenney
2024-06-04 17:04 ` Paul E. McKenney [this message]
2024-06-04 20:52 ` [PATCH v3 cmpxchg 4/4] ARM: " Linus Walleij
2024-06-04 21:14 ` Paul E. McKenney
2024-06-05 8:38 ` Linus Walleij
2024-06-05 18:05 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604170437.2362545-4-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=elver@google.com \
--cc=eric.devolder@oracle.com \
--cc=kernel-team@meta.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome