From: Douglas Anderson <dianders@chromium.org>
To: dri-devel@lists.freedesktop.org, Maxime Ripard <mripard@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Chris Morgan <macromorgan@hotmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Yuran Pereira <yuran.pereira@hotmail.com>,
Douglas Anderson <dianders@chromium.org>,
Jerry Han <jerry.han.hq@gmail.com>,
Jitao Shi <jitao.shi@mediatek.com>,
Rock Wang <rock_wang@himax.com.cn>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Jerry Han <hanxu5@huaqin.corp-partner.google.com>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: [PATCH v3 02/24] drm/panel: boe-himax8279d: Don't call unprepare+disable at shutdown/remove
Date: Tue, 4 Jun 2024 17:22:48 -0700 [thread overview]
Message-ID: <20240604172305.v3.2.I19086c524d38f28f746befe85cb39ffda9d2f666@changeid> (raw)
In-Reply-To: <20240605002401.2848541-1-dianders@chromium.org>
It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.
A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.
Unfortunately, grepping mainline for this panel's compatible string
shows no hits, so we can't be 100% sure if the DRM modeset driver used
with this panel has been fixed. If it is found that the DRM modeset
driver hasn't been fixed then this patch could be temporarily reverted
until it is.
[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org
Cc: Jerry Han <jerry.han.hq@gmail.com>
Cc: Jitao Shi <jitao.shi@mediatek.com>
Cc: Rock Wang <rock_wang@himax.com.cn>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/panel/panel-boe-himax8279d.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
index 12e14615298b..df746baae301 100644
--- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c
+++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
@@ -894,14 +894,6 @@ static void panel_remove(struct mipi_dsi_device *dsi)
struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
int err;
- err = drm_panel_disable(&pinfo->base);
- if (err < 0)
- dev_err(&dsi->dev, "failed to disable panel: %d\n", err);
-
- err = drm_panel_unprepare(&pinfo->base);
- if (err < 0)
- dev_err(&dsi->dev, "failed to unprepare panel: %d\n", err);
-
err = mipi_dsi_detach(dsi);
if (err < 0)
dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err);
@@ -909,14 +901,6 @@ static void panel_remove(struct mipi_dsi_device *dsi)
drm_panel_remove(&pinfo->base);
}
-static void panel_shutdown(struct mipi_dsi_device *dsi)
-{
- struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
-
- drm_panel_disable(&pinfo->base);
- drm_panel_unprepare(&pinfo->base);
-}
-
static struct mipi_dsi_driver panel_driver = {
.driver = {
.name = "panel-boe-himax8279d",
@@ -924,7 +908,6 @@ static struct mipi_dsi_driver panel_driver = {
},
.probe = panel_probe,
.remove = panel_remove,
- .shutdown = panel_shutdown,
};
module_mipi_dsi_driver(panel_driver);
--
2.45.1.288.g0e0cd299f1-goog
next prev parent reply other threads:[~2024-06-05 0:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 0:22 [PATCH v3 00/24] drm/panel: Remove most store/double-check of prepared/enabled state Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 01/24] drm/panel: boe-himax8279d: Stop tracking prepared/enabled Douglas Anderson
2024-06-05 0:22 ` Douglas Anderson [this message]
2024-06-05 0:22 ` [PATCH v3 03/24] drm/panel: khadas-ts050: " Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 04/24] drm/panel: khadas-ts050: Don't call unprepare+disable at shutdown/remove Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 05/24] drm/panel: olimex-lcd-olinuxino: Stop tracking prepared/enabled Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 06/24] drm/panel: olimex-lcd-olinuxino: Don't call unprepare+disable at remove Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 07/24] drm/panel: osd-osd101t2587-53ts: Stop tracking prepared/enabled Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 08/24] drm/panel: osd-osd101t2587-53ts: Don't call unprepare+disable at shutdown/remove Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 09/24] drm/panel: tdo-tl070wsh30: Stop tracking prepared Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 10/24] drm/panel: tdo-tl070wsh30: Don't call unprepare+disable at shutdown/remove Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 11/24] drm/panel: jdi-lt070me05000: Stop tracking prepared/enabled Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 12/24] drm/panel: jdi-lt070me05000: Don't call disable at shutdown/remove Douglas Anderson
2024-06-05 0:22 ` [PATCH v3 13/24] drm/panel: panasonic-vvx10f034n00: Stop tracking prepared/enabled Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 14/24] drm/panel: panasonic-vvx10f034n00: Don't call disable at shutdown/remove Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 15/24] drm/panel: seiko-43wvf1g: Stop tracking prepared/enabled Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 16/24] drm/panel: seiko-43wvf1g: Don't call disable at shutdown/remove Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 17/24] drm/panel: sharp-lq101r1sx01: Stop tracking prepared/enabled Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 18/24] drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 19/24] drm/panel: sharp-ls043t1le01: Stop tracking prepared Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 20/24] drm/panel: sharp-ls043t1le01: Don't call disable at shutdown/remove Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 21/24] drm/panel: raydium-rm67191: Stop tracking enabled Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 22/24] drm/panel: raydium-rm67191: Don't call unprepare+disable at shutdown Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 23/24] drm/panel: Update TODO list item for cleaning up prepared/enabled tracking Douglas Anderson
2024-06-05 0:23 ` [PATCH v3 24/24] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown Douglas Anderson
2024-06-11 7:56 ` [PATCH v3 00/24] drm/panel: Remove most store/double-check of prepared/enabled state Neil Armstrong
2024-06-11 8:02 ` (subset) " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604172305.v3.2.I19086c524d38f28f746befe85cb39ffda9d2f666@changeid \
--to=dianders@chromium.org \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hanxu5@huaqin.corp-partner.google.com \
--cc=jerry.han.hq@gmail.com \
--cc=jitao.shi@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=macromorgan@hotmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=rock_wang@himax.com.cn \
--cc=tzimmermann@suse.de \
--cc=yuran.pereira@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®