From: Primoz Fiser <primoz.fiser@norik.com>
To: "Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Douglas Anderson" <dianders@chromium.org>,
"Rob Herring" <robh@kernel.org>,
"Primoz Fiser" <primoz.fiser@norik.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: upstream@lists.phytec.de
Subject: [PATCH] drm/omap: dss: Support all VOUT ports
Date: Thu, 6 Jun 2024 10:28:50 +0200 [thread overview]
Message-ID: <20240606082850.3746052-1-primoz.fiser@norik.com> (raw)
Allow function dss_dpi_select_source_dra7xx() to set the channel in the
dra7xx DSS_CONTROL register for any VOUT port, not just VOUT1 (port 0).
Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
drivers/gpu/drm/omapdrm/dss/dss.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
index 988888e164d7..f5a484ef0f48 100644
--- a/drivers/gpu/drm/omapdrm/dss/dss.c
+++ b/drivers/gpu/drm/omapdrm/dss/dss.c
@@ -796,7 +796,9 @@ static int dss_dpi_select_source_dra7xx(struct dss_device *dss, int port,
{
switch (port) {
case 0:
- return dss_dpi_select_source_omap5(dss, port, channel);
+ if (channel != OMAP_DSS_CHANNEL_LCD)
+ return -EINVAL;
+ break;
case 1:
if (channel != OMAP_DSS_CHANNEL_LCD2)
return -EINVAL;
@@ -809,7 +811,7 @@ static int dss_dpi_select_source_dra7xx(struct dss_device *dss, int port,
return -EINVAL;
}
- return 0;
+ return dss_dpi_select_source_omap5(dss, port, channel);
}
int dss_dpi_select_source(struct dss_device *dss, int port,
--
2.25.1
reply other threads:[~2024-06-06 8:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606082850.3746052-1-primoz.fiser@norik.com \
--to=primoz.fiser@norik.com \
--cc=airlied@gmail.com \
--cc=andrew@codeconstruct.com.au \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®