mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>
Subject: [PATCH v1 6/6] leds: spi-byte: Move OF ID table closer to their user
Date: Thu,  6 Jun 2024 20:29:23 +0300	[thread overview]
Message-ID: <20240606173037.3091598-7-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240606173037.3091598-1-andriy.shevchenko@linux.intel.com>

There is no code that uses ID table directly, except the
struct device_driver at the end of the file. Hence, move
table closer to its user. It's always possible to access
them via a pointer.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/leds/leds-spi-byte.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/leds/leds-spi-byte.c b/drivers/leds/leds-spi-byte.c
index 985bbbed251b..d24d0ddf347c 100644
--- a/drivers/leds/leds-spi-byte.c
+++ b/drivers/leds/leds-spi-byte.c
@@ -56,13 +56,6 @@ static const struct spi_byte_chipdef ubnt_acb_spi_led_cdef = {
 	.max_value = 0x3F,
 };
 
-static const struct of_device_id spi_byte_dt_ids[] = {
-	{ .compatible = "ubnt,acb-spi-led", .data = &ubnt_acb_spi_led_cdef },
-	{},
-};
-
-MODULE_DEVICE_TABLE(of, spi_byte_dt_ids);
-
 static int spi_byte_brightness_set_blocking(struct led_classdev *dev,
 					    enum led_brightness brightness)
 {
@@ -122,6 +115,12 @@ static int spi_byte_probe(struct spi_device *spi)
 	return devm_led_classdev_register_ext(dev, &led->ldev, &init_data);
 }
 
+static const struct of_device_id spi_byte_dt_ids[] = {
+	{ .compatible = "ubnt,acb-spi-led", .data = &ubnt_acb_spi_led_cdef },
+	{}
+};
+MODULE_DEVICE_TABLE(of, spi_byte_dt_ids);
+
 static struct spi_driver spi_byte_driver = {
 	.probe		= spi_byte_probe,
 	.driver = {
-- 
2.43.0.rc1.1336.g36b5255a03ac


  parent reply	other threads:[~2024-06-06 17:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06 17:29 [PATCH v1 0/6] leds: spi-byte: Cleanup, fix a leak, and make it agnostic Andy Shevchenko
2024-06-06 17:29 ` [PATCH v1 1/6] leds: spi-byte: call of_node_put() on error path Andy Shevchenko
2024-06-06 17:54   ` Andy Shevchenko
2024-06-06 17:29 ` [PATCH v1 2/6] leds: spi-byte: Get rid of custom led_init_default_state_get() Andy Shevchenko
2024-06-06 17:29 ` [PATCH v1 3/6] leds: spi-byte: Make use of device properties Andy Shevchenko
2024-06-06 17:29 ` [PATCH v1 4/6] leds: spi-byte: Utilise temporary variable for struct device Andy Shevchenko
2024-06-06 17:29 ` [PATCH v1 5/6] leds: spi-byte: Use devm_mutex_init() for mutex initialization Andy Shevchenko
2024-06-06 17:29 ` Andy Shevchenko [this message]
2024-06-13 16:05 ` [PATCH v1 0/6] leds: spi-byte: Cleanup, fix a leak, and make it agnostic Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240606173037.3091598-7-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®