mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Ivan T. Ivanov" <iivanov@suse.de>
Cc: cve@kernel.org, linux-cve-announce@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: pwm: Fix double shift bug
Date: Sat, 8 Jun 2024 13:37:45 +0200	[thread overview]
Message-ID: <2024060807-monument-unlocked-781b@gregkh> (raw)
In-Reply-To: <20240605144305.78002-1-iivanov@suse.de>

On Wed, Jun 05, 2024 at 05:43:05PM +0300, Ivan T. Ivanov wrote:
> Hi,
> 
> I could argue that this is not CVE at all. It changes just bit positions.
> 
> -	PWMF_REQUESTED = 1 << 0,
> -	PWMF_EXPORTED = 1 << 1,
> +	PWMF_REQUESTED = 0,
> +	PWMF_EXPORTED = 1,
> 
> ie. before fix they 1 and 2 and after the fix 0, 1.
> 
> All call sites are using set/test_bit() on unsigned long flags.
> 
> Yes, double shift do not look right, but I don't see how
> this could lead to malfunction, let alone a CVE.

It could be an issue if the values were larger than 5 as the commit
says, but that's not the case here, so you are correct and this has now
been rejected as a cve.

Thanks for the review!

greg k-h

      reply	other threads:[~2024-06-08 11:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2024052146-CVE-2023-52756-f694@gregkh>
2024-06-05 14:43 ` Ivan T. Ivanov
2024-06-08 11:37   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024060807-monument-unlocked-781b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=cve@kernel.org \
    --cc=iivanov@suse.de \
    --cc=linux-cve-announce@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®