From: Tejas Vipin <tejasvipin76@gmail.com>
To: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com
Cc: Tejas Vipin <tejasvipin76@gmail.com>,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
linus.walleij@linaro.org, dmitry.baryshkov@linaro.org,
dianders@chromium.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] drm/mipi-dsi: fix handling of ctx in mipi_dsi_msleep
Date: Wed, 12 Jun 2024 19:05:43 +0530 [thread overview]
Message-ID: <20240612133550.473279-3-tejasvipin76@gmail.com> (raw)
In-Reply-To: <20240612133550.473279-1-tejasvipin76@gmail.com>
ctx would be better off treated as a pointer to account for most of its
usage so far, and brackets should be added to account for operator
precedence for correct evaluation.
Fixes: f79d6d28d8fe7 ("drm/mipi-dsi: wrap more functions for streamline handling")
Signed-off-by: Tejas Vipin <tejasvipin76@gmail.com>
---
include/drm/drm_mipi_dsi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
index bd5a0b6d0711..71d121aeef24 100644
--- a/include/drm/drm_mipi_dsi.h
+++ b/include/drm/drm_mipi_dsi.h
@@ -293,7 +293,7 @@ ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params,
#define mipi_dsi_msleep(ctx, delay) \
do { \
- if (!ctx.accum_err) \
+ if (!(ctx)->accum_err) \
msleep(delay); \
} while (0)
--
2.45.2
next prev parent reply other threads:[~2024-06-12 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 13:35 [PATCH 0/2] fix handling of incorrect arguments by mipi_dsi_msleep Tejas Vipin
2024-06-12 13:35 ` [PATCH 1/2] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep Tejas Vipin
2024-06-12 13:57 ` Doug Anderson
2024-06-12 13:35 ` Tejas Vipin [this message]
2024-06-12 14:21 ` [PATCH 2/2] drm/mipi-dsi: fix handling of ctx in mipi_dsi_msleep Doug Anderson
2024-06-12 14:34 ` neil.armstrong
2024-06-12 14:52 ` Doug Anderson
2024-06-12 15:00 ` neil.armstrong
2024-06-12 14:36 ` [PATCH 0/2] fix handling of incorrect arguments by mipi_dsi_msleep Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612133550.473279-3-tejasvipin76@gmail.com \
--to=tejasvipin76@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®