From: Isaku Yamahata <isaku.yamahata@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Isaku Yamahata <isaku.yamahata@intel.com>,
Michael Roth <michael.roth@amd.com>,
isaku.yamahata@linux.intel.com
Subject: Re: [PATCH] KVM: interrupt kvm_gmem_populate() on signals
Date: Wed, 12 Jun 2024 16:13:29 -0700 [thread overview]
Message-ID: <20240612231329.GA1900928@ls.amr.corp.intel.com> (raw)
In-Reply-To: <20240611102243.47904-1-pbonzini@redhat.com>
On Tue, Jun 11, 2024 at 06:22:43AM -0400,
Paolo Bonzini <pbonzini@redhat.com> wrote:
> kvm_gmem_populate() is a potentially lengthy operation that can involve
> multiple calls to the firmware. Interrupt it if a signal arrives.
What about cond_resched() in the loop? kvm_gmem_allocate() has both.
The change itself looks good for TDX because KVM_TDX_INIT_MEMREGION checks the
signal. I can drop the duplicated check. Similar to cond_resched().
--
Isaku Yamahata <isaku.yamahata@intel.com>
prev parent reply other threads:[~2024-06-12 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 10:22 Paolo Bonzini
2024-06-12 23:13 ` Isaku Yamahata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612231329.GA1900928@ls.amr.corp.intel.com \
--to=isaku.yamahata@intel.com \
--cc=isaku.yamahata@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®