From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D84A1411E1 for ; Thu, 13 Jun 2024 10:46:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718275596; cv=none; b=bi358ntmuxuVPCTu8igNVFchim6XZarj60AbVzLA12dFQNBQGNCaGOAxXrWJaMz/Ee6U1NHzU3N2x/anjnZh/orzgxVys1EqRh1bCQ+H7c2iHfY2jS9SYfViP10YFpn0alIgh9PevB8aJ+2iOQZzNx6bi3yd+tJ2kHNA5SM/M1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718275596; c=relaxed/simple; bh=zvynH4+/ZKi6EO3xPqDT8KhKU9w/4hcTOIDyS5SoVso=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tYUhjLfZewBD9M3jno/ETk53TY8PJfAw1ubdAeJ5/DsnEI7CRyHGmQ+Okl+jlDVBlPeZfKwz2qnluTdqbEDlDn90v/TpxNuEUe/QKVGnGyhClmcsqm+VI2VzQE2FvDKz5mTV8lCQPST3melF3ArsmEJKFk/jsyP2P9T7eBiYuQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=x3fqht00; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="x3fqht00" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42AA3C2BBFC; Thu, 13 Jun 2024 10:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718275595; bh=zvynH4+/ZKi6EO3xPqDT8KhKU9w/4hcTOIDyS5SoVso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x3fqht00QKPezzBfAiCoYVWYrvvO3do7G5v+OSlQ+tzyhRAtJ/m/a7+3BlPMb86J9 eiUKrY5u6QHs2fILzIvkTxMSMgupzI0Zc5hXsn/aYEjAf+Et+vuGtMc/ghpTePgL7b eEyqjeX7HEnc1NBC2EBMhsOgIoHUMzB6OUldDlLA= Date: Thu, 13 Jun 2024 12:46:33 +0200 From: Greg Kroah-Hartman To: Pavel Machek Cc: Lee Jones , Michal Hocko , cve@kernel.org, linux-kernel@vger.kernel.org, Felix Kuehling Subject: Re: CVE-2024-26628: drm/amdkfd: Fix lock dependency warning Message-ID: <2024061312-freebee-buffalo-4bd5@gregkh> References: <2024030649-CVE-2024-26628-f6ce@gregkh> <20240314110938.GM1522089@google.com> <20240320154734.GU1522089@google.com> <2024061335-wistful-brownnose-28ea@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 13, 2024 at 12:40:35PM +0200, Pavel Machek wrote: > On Thu 2024-06-13 12:16:50, Greg Kroah-Hartman wrote: > > On Thu, Jun 13, 2024 at 11:32:41AM +0200, Pavel Machek wrote: > > > On Wed 2024-03-20 15:47:34, Lee Jones wrote: > > > > On Wed, 20 Mar 2024, Michal Hocko wrote: > > > > > > > > > On Thu 14-03-24 11:09:38, Lee Jones wrote: > > > > > > On Fri, 08 Mar 2024, Michal Hocko wrote: > > > > > > > > > > > > > On Wed 06-03-24 06:46:11, Greg KH wrote: > > > > > > > [...] > > > > > > > > Possible unsafe locking scenario: > > > > > > > > > > > > > > > > CPU0 CPU1 > > > > > > > > ---- ---- > > > > > > > > lock(&svms->lock); > > > > > > > > lock(&mm->mmap_lock); > > > > > > > > lock(&svms->lock); > > > > > > > > lock((work_completion)(&svm_bo->eviction_work)); > > > > > > > > > > > > > > > > I believe this cannot really lead to a deadlock in practice, because > > > > > > > > svm_range_evict_svm_bo_worker only takes the mmap_read_lock if the BO > > > > > > > > refcount is non-0. That means it's impossible that svm_range_bo_release > > > > > > > > is running concurrently. However, there is no good way to annotate this. > > > > > > > > > > > > > > OK, so is this even a bug (not to mention a security/weakness)? > > > > > > > > > > > > Looks like the patch fixes a warning which can crash some kernels. So > > > > > > the CVE appears to be fixing that, rather than the impossible deadlock. > > > > > > > > > > Are you talking about lockdep warning or anything else? > > > > > > > > Anything that triggers a BUG() or a WARN() (as per the splat in the > > > > commit message). Many in-field kernels are configured to panic on > > > > BUG()s and WARN()s, thus triggering them are presently considered local > > > > DoS and attract CVE status. > > > > > > So... because it is possible to configure machine to reboot on > > > warning, now every warning is a security issue? > > > > > > Lockdep is for debugging, if someone uses it in production with panic > > > on reboot, they are getting exactly what they are asking for. > > > > > > Not a security problem. > > > > And we agree, I don't know what you are arguing about here, please stop. > > So you agree that WARN triggering randomly is not a security problem? > > Following communication did not say so. > > "The splat in the circular lockdep detection code appears to be generated > using some stacked pr_warn() calls, rather than a WARN()." *plonk*