From: Bjorn Helgaas <helgaas@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: add missing MODULE_DESCRIPTION() macros
Date: Thu, 13 Jun 2024 17:20:32 -0500 [thread overview]
Message-ID: <20240613222032.GA1087213@bhelgaas> (raw)
In-Reply-To: <20240610-md-drivers-pci-v1-1-139c135853ea@quicinc.com>
On Mon, Jun 10, 2024 at 06:21:16PM -0700, Jeff Johnson wrote:
> When ARCH=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-stub.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-pf-stub.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Applied to pci/misc for v6.11, with updates to the text:
> ---
> drivers/pci/pci-pf-stub.c | 1 +
> drivers/pci/pci-stub.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/pci/pci-pf-stub.c b/drivers/pci/pci-pf-stub.c
> index 45855a5e9fca..04815fcb0ce7 100644
> --- a/drivers/pci/pci-pf-stub.c
> +++ b/drivers/pci/pci-pf-stub.c
> @@ -39,4 +39,5 @@ static struct pci_driver pf_stub_driver = {
> };
> module_pci_driver(pf_stub_driver);
>
> +MODULE_DESCRIPTION("Simple stub driver for PCI SR-IOV PF device");
+MODULE_DESCRIPTION("SR-IOV PF stub driver with no functionality");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c
> index d1f4c1ce7bd1..d4fec791b321 100644
> --- a/drivers/pci/pci-stub.c
> +++ b/drivers/pci/pci-stub.c
> @@ -92,5 +92,6 @@ static void __exit pci_stub_exit(void)
> module_init(pci_stub_init);
> module_exit(pci_stub_exit);
>
> +MODULE_DESCRIPTION("Simple stub driver to reserve a PCI device");
+MODULE_DESCRIPTION("VM device assignment stub driver");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Chris Wright <chrisw@sous-sol.org>");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240610-md-drivers-pci-831cb8f308a9
>
next prev parent reply other threads:[~2024-06-13 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 1:21 Jeff Johnson
2024-06-13 22:20 ` Bjorn Helgaas [this message]
2024-06-13 22:22 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613222032.GA1087213@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®