From: Steven Rostedt <rostedt@goodmis.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: dongliang cui <cuidongliang390@gmail.com>,
Dongliang Cui <dongliang.cui@unisoc.com>,
axboe@kernel.dk, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, ebiggers@kernel.org,
ke.wang@unisoc.com, hongyu.jin.cn@gmail.com,
niuzhiguo84@gmail.com, hao_hao.wang@unisoc.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
akailash@google.com
Subject: Re: [PATCH v5] block: Add ioprio to block_rq tracepoint
Date: Mon, 17 Jun 2024 13:07:54 -0400 [thread overview]
Message-ID: <20240617130754.3b4dbd62@rorschach.local.home> (raw)
In-Reply-To: <84e024ba-b921-481c-a83d-eec0dd0e8328@acm.org>
On Mon, 17 Jun 2024 10:02:48 -0700
Bart Van Assche <bvanassche@acm.org> wrote:
> >> Do we really want to include the constant "[0]" in the tracing output?
> > This is how it is printed in the source code.
> > From the code flow point of view, there is no need to print this value
> > in trace_block_rq_requeue.
> > Do we need to consider the issue of uniform printing format? If not, I
> > think we can delete it.
>
> I'm not aware of any other tracing statement that prints out a constant.
> Is there perhaps something that I'm missing or overlooking?
The only time that is done, is if the trace event is used in multiple
places and there's one place that the value will always be the same.
-- Steve
next prev parent reply other threads:[~2024-06-17 17:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 7:49 Dongliang Cui
2024-06-14 16:40 ` Bart Van Assche
2024-06-17 7:59 ` dongliang cui
2024-06-17 17:02 ` Bart Van Assche
2024-06-17 17:07 ` Steven Rostedt [this message]
2024-06-17 21:30 ` Bart Van Assche
2024-06-18 0:28 ` Chaitanya Kulkarni
2024-06-28 6:38 ` dongliang cui
2024-06-28 16:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617130754.3b4dbd62@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akailash@google.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cuidongliang390@gmail.com \
--cc=dongliang.cui@unisoc.com \
--cc=ebiggers@kernel.org \
--cc=hao_hao.wang@unisoc.com \
--cc=hongyu.jin.cn@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=niuzhiguo84@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®