From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F6616CD27 for ; Tue, 18 Jun 2024 19:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718739858; cv=none; b=iLEPwHTu2ZiyZKQg2/z/R7I81LZXA1tzdkPxuvwNzMZ0oBnknrWK9bFKmUoFTQuQl4zGV9mDmH6z7sU8097RKRCogEWbXgimmMlUY+AlAb6SwFoFsYSxLfXde0dM9kcEXVZ/epmVTjibkoRJ5KhwaL6nU0jt3B2EV9wT7UtPeyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718739858; c=relaxed/simple; bh=rIJ5+GUJI1PTS3Z7ZAUJY72TPUFyF93XiS+gkPOXsT8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=niQiYc4xHQY84vTwua/ixo9neVgbW24w+pNv3BjUgZ1ToLHKWkYE7J4MB+jNgEq9oUFtPmQXmiRB0uaihFwM3BVmIk6HjjPncCvtjxMCmViUMpC6siiMTuwQ9vRgx5hv6HW+yD2s7tUuXlMz7SDE/3fRWUYYOOp3/32WGVNOxwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=NambipHs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="NambipHs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD95DC3277B; Tue, 18 Jun 2024 19:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718739858; bh=rIJ5+GUJI1PTS3Z7ZAUJY72TPUFyF93XiS+gkPOXsT8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NambipHs6oeTEEEduV4YC6xIap54zm9+xZq6yO1xkiPG7yW2XUNCq3CS2YJruMwWG fJ8YwSTxZAWzs9MDxacG7cRDB51dOXBqE6LH4Oy7WGqXBy8+v1DuL3qJsbPZbD9RLP b1EvcEfh3nAoZykcYn5gMklmKxXBOPytrBelKQg0= Date: Tue, 18 Jun 2024 12:44:17 -0700 From: Andrew Morton To: Zi Yan Cc: Zi Yan , Hugh Dickins , "Huang, Ying" , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Yang Shi , David Hildenbrand , Yin Fengwei , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent. Message-Id: <20240618124417.08745f6c08f6ecb2c959a096@linux-foundation.org> In-Reply-To: <20240618134151.29214-1-zi.yan@sent.com> References: <20240618134151.29214-1-zi.yan@sent.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 18 Jun 2024 09:41:51 -0400 Zi Yan wrote: > From: Zi Yan > > As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to > avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when > calling migrate_pages_batch(). > Thanks. I'll add Fixes: 7262f208ca68 ("mm/migrate: split source folio if it is on deferred split list") and shall queue it for 6.10-rcX. Please don't forget such details.