From: Jan Kara <jack@suse.cz>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, NeilBrown <neilb@suse.de>,
Amir Goldstein <amir73il@gmail.com>,
James Clark <james.clark@arm.com>,
ltp@lists.linux.it, linux-nfs@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2] VFS: generate FS_CREATE before FS_OPEN when ->atomic_open used.
Date: Thu, 20 Jun 2024 11:41:51 +0200 [thread overview]
Message-ID: <20240620094151.cuamehtaioenokyv@quack3> (raw)
In-Reply-To: <20240618-wahr-drossel-19297ad2a361@brauner>
On Tue 18-06-24 16:19:37, Christian Brauner wrote:
> > AFAICT this will have a side-effect that now fsnotify_open() will be
> > generated even for O_PATH open. It is true that fsnotify_close() is getting
>
> Thanks! That change seemed sensible because a close() event is
> generated.
>
> But I don't agree that generating events for O_PATH fds doesn't make
> sense on principle. But I don't care if you drop events for O_PATH now.
Well, I can be convinced otherwise but I was not able to find a compeling
usecase for it. fanotify(8) users primarily care about file data
modification / access events and secondarily also about directory content
changes (because they change how data can be accessed). And creation of
O_PATH fds does not seem to fall into either of these categories...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-06-20 9:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 7:09 NeilBrown
2024-06-12 10:27 ` James Clark
2024-06-12 10:34 ` Amir Goldstein
2024-06-12 11:47 ` NeilBrown
2024-06-13 7:38 ` Amir Goldstein
2024-06-12 13:53 ` Christian Brauner
2024-06-13 7:31 ` Amir Goldstein
2024-06-15 5:35 ` Christian Brauner
2024-06-17 9:37 ` Jan Kara
2024-06-17 12:09 ` Amir Goldstein
2024-06-17 13:07 ` Jan Kara
2024-06-17 13:49 ` Amir Goldstein
2024-06-17 15:51 ` Jan Kara
2024-06-18 14:19 ` Christian Brauner
2024-06-20 9:41 ` Jan Kara [this message]
2024-06-20 10:04 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620094151.cuamehtaioenokyv@quack3 \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=james.clark@arm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=neilb@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®