From: Anna-Maria Behnsen <anna-maria@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Cc: Borislav Petkov <bp@alien8.de>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Narasimhan V <Narasimhan.V@amd.com>
Subject: [PATCH 0/3] timer_migration: Fix a possible race and improvements
Date: Fri, 21 Jun 2024 11:37:05 +0200 [thread overview]
Message-ID: <20240621-tmigr-fixes-v1-0-8c8a2d8e8d77@linutronix.de> (raw)
Borislav reported a warning in timer migration deactive path
https://lore.kernel.org/r/20240612090347.GBZmlkc5PwlVpOG6vT@fat_crate.local
Sadly it doesn't reproduce directly. But with the change of timing (by
adding a trace prinkt before the warning), it is possible to trigger the
warning reliable at least in my test setup. The problem here is a racy
check agains group->parent pointer. This is also used in other places in
the code and fixing this racy usage is adressed by the first patch.
While working with the code, I saw two things which could be improved
(tracing and update of per cpu group wakeup value). This improvements are
adressed by the other two patches.
Patches are available here:
https://git.kernel.org/pub/scm/linux/kernel/git/anna-maria/linux-devel.git timers/misc
Cc: Frederic Weisbecker <frederic@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Thanks,
Anna-Maria
---
Anna-Maria Behnsen (3):
timer_migration: Do not rely always on group->parent
timer_migration: Spare write when nothing changed
timer_migration: Improve tracing
kernel/time/timer_migration.c | 55 ++++++++++++++++++++-----------------------
kernel/time/timer_migration.h | 12 +++++++++-
2 files changed, 36 insertions(+), 31 deletions(-)
next reply other threads:[~2024-06-21 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 9:37 Anna-Maria Behnsen [this message]
2024-06-21 9:37 ` [PATCH 1/3] timer_migration: Do not rely always on group->parent Anna-Maria Behnsen
2024-06-21 9:37 ` [PATCH 2/3] timer_migration: Spare write when nothing changed Anna-Maria Behnsen
2024-06-21 9:37 ` [PATCH 3/3] timer_migration: Improve tracing Anna-Maria Behnsen
2024-06-21 14:31 ` [PATCH 0/3] timer_migration: Fix a possible race and improvements Frederic Weisbecker
2024-06-24 8:58 ` Anna-Maria Behnsen
2024-06-24 11:04 ` Frederic Weisbecker
2024-06-24 14:48 ` Anna-Maria Behnsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621-tmigr-fixes-v1-0-8c8a2d8e8d77@linutronix.de \
--to=anna-maria@linutronix.de \
--cc=Narasimhan.V@amd.com \
--cc=bp@alien8.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®