mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wentong Wu <wentong.wu@intel.com>
To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com,
	gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Wentong Wu <wentong.wu@intel.com>,
	stable@vger.kernel.org, Jason Chen <jason.z.chen@intel.com>
Subject: [PATCH 2/6] mei: vsc: Enhance IVSC chipset stability during warm reboot
Date: Sun, 23 Jun 2024 17:30:52 +0800	[thread overview]
Message-ID: <20240623093056.4169438-3-wentong.wu@intel.com> (raw)
In-Reply-To: <20240623093056.4169438-1-wentong.wu@intel.com>

During system shutdown, incorporate reset logic to ensure the IVSC
chipset remains in a valid state. This adjustment guarantees that
the IVSC chipset operates in a known state following a warm reboot.

Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
Cc: stable@vger.kernel.org # for 6.8+
Signed-off-by: Wentong Wu <wentong.wu@intel.com>
Tested-by: Jason Chen <jason.z.chen@intel.com>
---
 drivers/misc/mei/vsc-tp.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
index dcab5174bf00..4595b1a25536 100644
--- a/drivers/misc/mei/vsc-tp.c
+++ b/drivers/misc/mei/vsc-tp.c
@@ -570,6 +570,19 @@ static void vsc_tp_remove(struct spi_device *spi)
 	free_irq(spi->irq, tp);
 }
 
+static void vsc_tp_shutdown(struct spi_device *spi)
+{
+	struct vsc_tp *tp = spi_get_drvdata(spi);
+
+	platform_device_unregister(tp->pdev);
+
+	mutex_destroy(&tp->mutex);
+
+	vsc_tp_reset(tp);
+
+	free_irq(spi->irq, tp);
+}
+
 static const struct acpi_device_id vsc_tp_acpi_ids[] = {
 	{ "INTC1009" }, /* Raptor Lake */
 	{ "INTC1058" }, /* Tiger Lake */
@@ -582,6 +595,7 @@ MODULE_DEVICE_TABLE(acpi, vsc_tp_acpi_ids);
 static struct spi_driver vsc_tp_driver = {
 	.probe = vsc_tp_probe,
 	.remove = vsc_tp_remove,
+	.shutdown = vsc_tp_shutdown,
 	.driver = {
 		.name = "vsc-tp",
 		.acpi_match_table = vsc_tp_acpi_ids,
-- 
2.34.1


  parent reply	other threads:[~2024-06-23  9:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-23  9:30 [PATCH 0/6] Fix MEI command timeout issue following " Wentong Wu
2024-06-23  9:30 ` [PATCH 1/6] mei: vsc: Enhance IVSC chipset reset toggling Wentong Wu
2024-06-23 10:06   ` Sakari Ailus
2024-06-23 10:48     ` Wu, Wentong
2024-06-23  9:30 ` Wentong Wu [this message]
2024-06-23  9:30 ` [PATCH 3/6] mei: vsc: Enhance SPI transfer of IVSC rom Wentong Wu
2024-06-23 10:09   ` Sakari Ailus
2024-06-23 10:42     ` Wu, Wentong
2024-06-23  9:30 ` [PATCH 4/6] mei: vsc: Utilize the appropriate byte order swap function Wentong Wu
2024-06-23  9:30 ` [PATCH 5/6] mei: vsc: Prevent timeout error with added delay post-firmware download Wentong Wu
2024-06-23  9:30 ` [PATCH 6/6] mei: vsc: Fix spelling error Wentong Wu
2024-06-23 10:08   ` Sakari Ailus
2024-06-23 10:30     ` Wu, Wentong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240623093056.4169438-3-wentong.wu@intel.com \
    --to=wentong.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason.z.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stable@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®