From: Liu Wei <liuwei09@cestc.cn>
To: andrew@lunn.ch, Liu Wei <liuwei09@cestc.cn>
Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, prarit@redhat.com, will@kernel.org
Subject: Re: [PATCH V3] ACPI: Add acpi=nospcr to disable ACPI SPCR as default console on arm64
Date: Mon, 24 Jun 2024 13:04:04 +0800 [thread overview]
Message-ID: <20240624050404.84512-1-liuwei09@cestc.cn> (raw)
In-Reply-To: <f706cb73-4219-47fb-a075-e591502be7c2@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
> On Sat, Jun 22, 2024 at 05:35:21PM +0800, Liu Wei wrote:
> > For varying privacy and security reasons, sometimes we would like to
> > completely silence the serial console, and only enable it when needed.
> >
> > But there are many existing systems that depend on this console,
> > so add acpi=nospcr for this situation.
>
> Maybe it is just me, but i see nospcr and my brain expands it to "no
> speaker". Adding to that, your commit message says "completely
> silence"...
>
> > + nospcr -- disable ACPI SPCR as default console on ARM64
> > + For ARM64, ONLY "acpi=off", "acpi=on", "acpi=force" or
> > + "acpi=nospcr" are available
> > + For RISCV64, ONLY "acpi=off", "acpi=on" or "acpi=force"
> > + are available
>
> How about putting the word 'serial' in here somewhere, just to give
> users an additional clue you are not talking about a speaker, CTRL-G
> etc.
Thank you for your suggestion.
You mean acpi=nospcr_serial or acpi=no_spcrserial? However, it appears
somewhat unconventional compared to the original acpi=* parameter.
How about introducing a new one, such as acpi_no_spcr_serial or
acpi_no_spcr_console?
Best wishes,
Liu Wei
> Andrew
next prev parent reply other threads:[~2024-06-24 5:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 1:53 [PATCH] ACPI: Do not enable ACPI SPCR console by default " Liu Wei
2024-05-30 13:06 ` Prarit Bhargava
2024-06-18 15:29 ` Will Deacon
2024-06-18 16:40 ` Sudeep Holla
2024-06-19 3:43 ` Liu Wei
2024-06-20 12:04 ` Prarit Bhargava
2024-06-21 4:37 ` Liu Wei
2024-05-31 1:52 ` Liu Wei
2024-06-21 4:47 ` [PATCH v2] ACPI: Add config to disable " Liu Wei
2024-06-21 11:26 ` Prarit Bhargava
2024-06-21 16:39 ` Liu Wei
2024-06-22 9:35 ` [PATCH V3] ACPI: Add acpi=nospcr to disable ACPI SPCR as default console " Liu Wei
2024-06-22 17:05 ` Andrew Lunn
2024-06-24 5:04 ` Liu Wei [this message]
2024-06-24 14:42 ` Will Deacon
2024-06-24 15:10 ` Andrew Lunn
2024-06-25 2:48 ` Liu Wei
2024-06-25 3:05 ` [PATCH v4] ACPI: Add acpi=nospcr to disable ACPI SPCR as default console on ARM64 Liu Wei
2024-06-25 12:58 ` Prarit Bhargava
2024-06-26 3:07 ` Liu Wei
2024-06-26 7:54 ` Hanjun Guo
2024-07-04 16:22 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624050404.84512-1-liuwei09@cestc.cn \
--to=liuwei09@cestc.cn \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®