Re: [PATCH v8] usb: typec: ucsi: add Lenovo Yoga C630 glue driver

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Jun 21, 2024 at 01:21:26AM +0300, Dmitry Baryshkov wrote:
> The Lenovo Yoga C630 WOS laptop provides implements UCSI interface in
> the onboard EC. Add glue driver to interface the platform's UCSI
> implementation.
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Add driver for the UCSI on the Lenovo Yoga C630 laptop, as implemented
> by the Embedded Controlller of the laptop.
> 
> Support for this EC was implemented by Bjorn, who later could not work
> on this driver. I've picked this patchset up and updated it following
> the pending review comments.
> 
> NOTE: the patch depends on the header from the platform driver. Ilpo
> Järvinen has created an immutable branch based on v6.10-rc1, please pull
> it before merging the patches:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git tags/platform-drivers-x86-ib-lenovo-c630-v6.11
> 
>   platform: arm64: add Lenovo Yoga C630 WOS EC driver (2024-06-14 12:51:30 +0300)

I have that branch, yet when building this driver as a module I get the
following errors:
ERROR: modpost: "yoga_c630_ec_unregister_notify" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!
ERROR: modpost: "yoga_c630_ec_ucsi_get_version" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!
ERROR: modpost: "yoga_c630_ec_register_notify" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!
ERROR: modpost: "yoga_c630_ec_ucsi_write" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!
ERROR: modpost: "yoga_c630_ec_ucsi_read" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!

So something went wrong :(

I'll unwind that branch pull now as well and wait for a fixed up version
to be sent.

thanks,

greg k-h