From: Wentong Wu <wentong.wu@intel.com>
To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com,
gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Wentong Wu <wentong.wu@intel.com>
Subject: [PATCH v3 0/5] Fix MEI command timeout issue following warm reboot
Date: Mon, 24 Jun 2024 21:28:44 +0800 [thread overview]
Message-ID: <20240624132849.4174494-1-wentong.wu@intel.com> (raw)
While enabling the IVSC on certain recent commercial products, the chipset
may occasionally enter an unknown state following a warm reboot. This issue
can cause the firmware to fail in responding to the MEI command from the
host, despite the firmware being re-downloaded. To resolve this, the current
patch set incorporates reset logic during system shutdown to ensure that the
IVSC chipset remains in a valid state after a warm reboot.
Furthermore, after the firmware download is complete, the firmware requires
some time to become operational. To enhance this, additional sleep time has
been introduced before the initial read operation to prevent a confusing
timeout error in vsc_tp_xfer().
Additionally, this patch set includes several enhancements as well:
1) utilizing the appropriate byte order swap function for data received
from the ROM;
2) correcting a spelling error in a comment;
3) constructing the SPI transfer command as per the specific request.
---
v2 -> v3:
- switch code from `ibuf ? tp->rx_buf : ibuf` to `ibuf ? tp->rx_buf : NULL`
v1 -> v2:
- remove cc spelling fix to stable
- remove the reset toggling enhancement
Wentong Wu (5):
mei: vsc: Enhance IVSC chipset stability during warm reboot
mei: vsc: Enhance SPI transfer of IVSC rom
mei: vsc: Utilize the appropriate byte order swap function
mei: vsc: Prevent timeout error with added delay post-firmware
download
mei: vsc: Fix spelling error
drivers/misc/mei/platform-vsc.c | 4 ++--
drivers/misc/mei/vsc-fw-loader.c | 2 +-
drivers/misc/mei/vsc-tp.c | 18 ++++++++++++++++--
3 files changed, 19 insertions(+), 5 deletions(-)
--
2.34.1
next reply other threads:[~2024-06-24 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 13:28 Wentong Wu [this message]
2024-06-24 13:28 ` [PATCH v3 1/5] mei: vsc: Enhance IVSC chipset stability during " Wentong Wu
2024-06-24 13:28 ` [PATCH v3 2/5] mei: vsc: Enhance SPI transfer of IVSC rom Wentong Wu
2024-06-24 14:29 ` Winkler, Tomas
2024-06-24 13:28 ` [PATCH v3 3/5] mei: vsc: Utilize the appropriate byte order swap function Wentong Wu
2024-06-24 13:28 ` [PATCH v3 4/5] mei: vsc: Prevent timeout error with added delay post-firmware download Wentong Wu
2024-06-24 13:28 ` [PATCH v3 5/5] mei: vsc: Fix spelling error Wentong Wu
2024-06-24 14:31 ` Greg KH
2024-06-25 0:39 ` Wu, Wentong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624132849.4174494-1-wentong.wu@intel.com \
--to=wentong.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®