From: Davidlohr Bueso <dave@stgolabs.net>
To: Huang Ying <ying.huang@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
Alison Schofield <alison.schofield@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Bharata B Rao <bharata@amd.com>,
Alistair Popple <apopple@nvidia.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH v3 1/3] cxl/region: Fix a race condition in memory hotplug notifier
Date: Mon, 24 Jun 2024 09:18:41 -0700 [thread overview]
Message-ID: <20240624161841.gekjnoksxrb4zd7x@offworld> (raw)
In-Reply-To: <20240618084639.1419629-2-ying.huang@intel.com>
On Tue, 18 Jun 2024, Huang Ying wrote:
>In the memory hotplug notifier function of the CXL region,
>cxl_region_perf_attrs_callback(), the node ID is obtained by checking
>the host address range of the region. However, the address range
>information is not available when the region is registered in
>devm_cxl_add_region(). Additionally, this information may be removed
>or added under the protection of cxl_region_rwsem during runtime. If
>the memory notifier is called for nodes other than that backed by the
>region, a race condition may occur, potentially leading to a NULL
>dereference or an invalid address range.
>
>The race condition is addressed by checking the availability of the
>address range information under the protection of cxl_region_rwsem. To
>enhance code readability and use guard(), the relevant code has been
>moved into a newly added function: cxl_region_nid().
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
next prev parent reply other threads:[~2024-06-24 16:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 8:46 [PATCH v3 0/3] cxl/region: Support to calculate memory tier abstract distance Huang Ying
2024-06-18 8:46 ` [PATCH v3 1/3] cxl/region: Fix a race condition in memory hotplug notifier Huang Ying
2024-06-20 11:10 ` Jonathan Cameron
2024-06-24 16:18 ` Davidlohr Bueso [this message]
2024-07-23 14:31 ` Gregory Price
2024-07-23 17:00 ` fan
2024-06-18 8:46 ` [PATCH v3 2/3] cxl/region: Support to calculate memory tier abstract distance Huang Ying
2024-06-20 11:13 ` Jonathan Cameron
2024-07-23 14:49 ` Gregory Price
2024-07-23 17:40 ` fan
2024-06-18 8:46 ` [PATCH v3 3/3] cxl/region: Simplify cxl_region_nid() Huang Ying
2024-06-20 11:15 ` Jonathan Cameron
2024-06-21 2:25 ` Huang, Ying
2024-06-24 15:24 ` Dave Jiang
2024-07-23 14:50 ` Gregory Price
2024-07-23 17:49 ` fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624161841.gekjnoksxrb4zd7x@offworld \
--to=dave@stgolabs.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=apopple@nvidia.com \
--cc=bharata@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®