From: Wentong Wu <wentong.wu@intel.com>
To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com,
gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Wentong Wu <wentong.wu@intel.com>,
Jason Chen <jason.z.chen@intel.com>
Subject: [PATCH v4 4/5] mei: vsc: Enhance SPI transfer of IVSC ROM
Date: Tue, 25 Jun 2024 16:10:46 +0800 [thread overview]
Message-ID: <20240625081047.4178494-5-wentong.wu@intel.com> (raw)
In-Reply-To: <20240625081047.4178494-1-wentong.wu@intel.com>
Before downloading firmware, a command response is required to
identify the silicon. However, when downloading IVSC firmware,
reading data from the SPI transfers with the IVSC ROM is not
necessary. Therefore, the rx buffer of SPI transfer command is
determined based on the specific request of the caller.
Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
Signed-off-by: Wentong Wu <wentong.wu@intel.com>
Tested-by: Jason Chen <jason.z.chen@intel.com>
---
drivers/misc/mei/vsc-tp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
index 876330474444..1618cca9a731 100644
--- a/drivers/misc/mei/vsc-tp.c
+++ b/drivers/misc/mei/vsc-tp.c
@@ -331,7 +331,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf, void *ibuf, size_t len)
return ret;
}
- ret = vsc_tp_dev_xfer(tp, tp->tx_buf, tp->rx_buf, len);
+ ret = vsc_tp_dev_xfer(tp, tp->tx_buf, ibuf ? tp->rx_buf : NULL, len);
if (ret)
return ret;
--
2.34.1
next prev parent reply other threads:[~2024-06-25 8:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 8:10 [PATCH v4 0/5] Fix MEI command timeout issue following warm reboot Wentong Wu
2024-06-25 8:10 ` [PATCH v4 1/5] mei: vsc: Enhance IVSC chipset stability during " Wentong Wu
2024-06-25 8:45 ` Sakari Ailus
2024-06-25 8:10 ` [PATCH v4 2/5] mei: vsc: Prevent timeout error with added delay post-firmware download Wentong Wu
2024-06-25 8:45 ` Sakari Ailus
2024-06-25 8:10 ` [PATCH v4 3/5] mei: vsc: Utilize the appropriate byte order swap function Wentong Wu
2024-06-25 8:45 ` Sakari Ailus
2024-06-25 8:10 ` Wentong Wu [this message]
2024-06-25 8:45 ` [PATCH v4 4/5] mei: vsc: Enhance SPI transfer of IVSC ROM Sakari Ailus
2024-06-27 8:26 ` Winkler, Tomas
2024-06-25 8:10 ` [PATCH v4 5/5] mei: vsc: Fix spelling error Wentong Wu
2024-06-25 8:44 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625081047.4178494-5-wentong.wu@intel.com \
--to=wentong.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jason.z.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®