From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C150149C4C; Tue, 25 Jun 2024 11:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719314830; cv=none; b=m4A1fYpZnmMBwF3mBlNali30zb+9FjDbuFfKqBY+2fOTVbaZnQQnP7lh67zUrD2CAS+N0gc/eFQwPtUfPMKQ4atG/thLt3G6+QPFcgXC+rLpqGFMQhDDm6zorFiTySqESx5yYc6wNmMb6ovhpclwJ2RiZ0EhcWqv1nM4ChSaBq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719314830; c=relaxed/simple; bh=zzrLgFHfkFUFx4FQA7l293B59+LWvaKIkSGrLRG/HoQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F2PAExDx/4PqVKpR5P76pNkePESdpEAKrbdLgqRGWJk/QptCLixl24+Fr443Vxq969gdEpGYsxRmQK8Z0SsY9N3/G62nbtX1IlPMeJtcJAfxI42dV9y0Sw4ja7ocqWYsauehdSlnaMJ3VZwqx7Q9IRZg2luILmCdXS3nFcH58FY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vLSaoF5j; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vLSaoF5j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8153FC32781; Tue, 25 Jun 2024 11:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719314830; bh=zzrLgFHfkFUFx4FQA7l293B59+LWvaKIkSGrLRG/HoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vLSaoF5j3kRrpHLLGQOBjKAy8fabqTMjHscooWo+Cf0qVlm97HWZ4lcUHD2ltKPKr kVuMSIOGw7aaRJiXZG4t++d6Lz5tkAkMhuwK1MvbhK5yryIewBLyc2YJiwGWNnMol+ K0cnvR7u7zNUhuTLY8P7SLGHuq13WRfUCGJyymzVdHfN+0s9MllWZ2HDBmYI/ARd2n AV2qttBwbzZGzK5Pl39knyr0JpHaASLq9cOF1NuSWNGwwzNQQWdeowXbIEE7cc0ENz q0Jh+K1YcITaJ5Yg3cfKWHqbKIlM+CZ0Yacw8HhAz0aTucwFaE8AoF5RMLSCOUMlHf OaNOFFDWlcy5g== Date: Tue, 25 Jun 2024 12:27:04 +0100 From: Will Deacon To: Rob Clark Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Robin Murphy , Joerg Roedel , Jason Gunthorpe , Boris Brezillon , Kevin Tian , Joao Martins , "moderated list:ARM SMMU DRIVERS" , "open list:IOMMU SUBSYSTEM" , open list Subject: Re: [PATCH v4 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk Message-ID: <20240625112703.GA10175@willie-the-truck> References: <20240523175227.117984-1-robdclark@gmail.com> <20240523175227.117984-2-robdclark@gmail.com> <20240624151401.GB8706@willie-the-truck> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) On Mon, Jun 24, 2024 at 08:37:26AM -0700, Rob Clark wrote: > On Mon, Jun 24, 2024 at 8:14 AM Will Deacon wrote: > > > > On Thu, May 23, 2024 at 10:52:21AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Add an io-pgtable method to walk the pgtable returning the raw PTEs that > > > would be traversed for a given iova access. > > > > > > Signed-off-by: Rob Clark > > > --- > > > drivers/iommu/io-pgtable-arm.c | 51 ++++++++++++++++++++++++++++------ > > > include/linux/io-pgtable.h | 4 +++ > > > 2 files changed, 46 insertions(+), 9 deletions(-) > > > > > > diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c > > > index f7828a7aad41..f47a0e64bb35 100644 > > > --- a/drivers/iommu/io-pgtable-arm.c > > > +++ b/drivers/iommu/io-pgtable-arm.c > > > @@ -693,17 +693,19 @@ static size_t arm_lpae_unmap_pages(struct io_pgtable_ops *ops, unsigned long iov > > > data->start_level, ptep); > > > } > > > > > > -static phys_addr_t arm_lpae_iova_to_phys(struct io_pgtable_ops *ops, > > > - unsigned long iova) > > > +static int arm_lpae_pgtable_walk(struct io_pgtable_ops *ops, unsigned long iova, > > > + int (*cb)(void *cb_data, void *pte, int level), > > > + void *cb_data) > > > { > > > struct arm_lpae_io_pgtable *data = io_pgtable_ops_to_data(ops); > > > arm_lpae_iopte pte, *ptep = data->pgd; > > > int lvl = data->start_level; > > > + int ret; > > > > > > do { > > > /* Valid IOPTE pointer? */ > > > if (!ptep) > > > - return 0; > > > + return -EFAULT; > > > > nit: -ENOENT might be a little better, as we're only checking against a > > NULL entry rather than strictly any faulting entry. > > > > > /* Grab the IOPTE we're interested in */ > > > ptep += ARM_LPAE_LVL_IDX(iova, lvl, data); > > > @@ -711,22 +713,52 @@ static phys_addr_t arm_lpae_iova_to_phys(struct io_pgtable_ops *ops, > > > > > > /* Valid entry? */ > > > if (!pte) > > > - return 0; > > > + return -EFAULT; > > > > Same here (and at the end of the function). > > > > > + > > > + ret = cb(cb_data, &pte, lvl); > > > > Since pte is on the stack, rather than pointing into the actual pgtable, > > I think it would be clearer to pass it by value to the callback. > > fwiw, I passed it as a void* to avoid the pte size.. although I guess > it could be a union of all the possible pte types Can you just get away with a u64? Will