mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suman Ghosh <sumang@marvell.com>
To: <sgoutham@marvell.com>, <gakula@marvell.com>,
	<sbhatta@marvell.com>, <hkelam@marvell.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <lcherian@marvell.com>,
	<jerinj@marvell.com>, <markus.elfring@web.de>
Cc: Suman Ghosh <sumang@marvell.com>
Subject: [net PATCH v2 1/7] octeontx2-af: Fix klockwork issue in cgx.c
Date: Tue, 25 Jun 2024 23:03:43 +0530	[thread overview]
Message-ID: <20240625173350.1181194-2-sumang@marvell.com> (raw)
In-Reply-To: <20240625173350.1181194-1-sumang@marvell.com>

Variable "cgx_dev" and "lmac" was getting accessed without NULL checks
which can lead to pointer exception in some erroneous scenarios.
This patch fixes the same by adding the required NULL checks.

Fixes: 96be2e0da85e ("octeontx2-af: Support for MAC address filters in CGX")
Signed-off-by: Suman Ghosh <sumang@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
index 27935c54b91b..e5e266608cfc 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
@@ -465,6 +465,13 @@ u64 cgx_lmac_addr_get(u8 cgx_id, u8 lmac_id)
 	u64 cfg;
 	int id;
 
+	if (!cgx_dev)
+		return 0;
+
+	lmac = lmac_pdata(lmac_id, cgx_dev);
+	if (!lmac)
+		return 0;
+
 	mac_ops = cgx_dev->mac_ops;
 
 	id = get_sequence_id_of_lmac(cgx_dev, lmac_id);
-- 
2.25.1


  reply	other threads:[~2024-06-25 17:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 17:33 [net PATCH v2 0/7] octeontx2-af: Fix klockwork issues in AF driver Suman Ghosh
2024-06-25 17:33 ` Suman Ghosh [this message]
2024-06-26  1:04   ` [net PATCH v2 1/7] octeontx2-af: Fix klockwork issue in cgx.c Jakub Kicinski
2024-06-25 17:33 ` [net PATCH v2 2/7] octeontx2-af: Fix klockwork issue in mcs_rvu_if.c Suman Ghosh
2024-06-25 17:33 ` [net PATCH 2/7] octeontx2-af: Fix klockwork issues " Suman Ghosh
2024-06-25 18:37   ` Markus Elfring
2024-06-25 17:33 ` [net PATCH v2 3/7] octeontx2-af: Fixes klockwork issues in ptp.c Suman Ghosh
2024-06-25 17:33 ` [net PATCH v2 4/7] octeontx2-af: Fixes klockwork issues in rvu_cpt.c Suman Ghosh
2024-06-25 17:33 ` [net PATCH v2 5/7] octeontx2-af: Fixes klockwork issues in rvu_debugfs.c Suman Ghosh
2024-06-25 17:33 ` [net PATCH v2 6/7] octeontx2-af: Fix klockwork issue in rvu_nix.c Suman Ghosh
2024-06-25 17:33 ` [net PATCH v2 7/7] octeontx2-af: Fix klockwork issue in rvu_npc.c Suman Ghosh
2024-06-25 18:17 ` [net PATCH v2 0/7] octeontx2-af: Fix klockwork issues in AF driver Markus Elfring
     [not found]   ` <SJ0PR18MB52166806AA7FB13ED3DC3E39DBD52@SJ0PR18MB5216.namprd18.prod.outlook.com>
2024-06-25 19:50     ` Markus Elfring
2024-06-26  1:04     ` [EXTERNAL] " Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240625173350.1181194-2-sumang@marvell.com \
    --to=sumang@marvell.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=kuba@kernel.org \
    --cc=lcherian@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.elfring@web.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®