From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6F641C2A8 for ; Thu, 27 Jun 2024 05:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719467512; cv=none; b=YVootTDic+aE2rXZWHSuJAgrJvBgrIpwOF5bLgLO/9Eb4u36qv0eXSy2YWN6/zGp+Mg1dixygscZWe/lbyPNPFlGOLwgQ1ROcUzJtVyJquLbd4COAnmSQenaX+oSd+X4Z5OZ3jvzQEaG+bAuifna6y/xxN11QCwavmHQkCfFJAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719467512; c=relaxed/simple; bh=MjC6jg1cIfNCnzYIKAL8YOD/Zr+JXQRGzsHAgYR/sV0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O5YgGTX2DHjqf5sQdBy3MVqBGVtYFFMtsi2oST1Sb6VhpfP1zSkS1oysA5LFJJZ3KrcxHuG8jd3hQQ2GIn4SlKXM09Jl7pVYqAFov6xLlmyJkpJnLRna0l0nNIy0VUFkc76LUneOgmFDxvzl2/Prd2gD/XoNon51FgVJCDtaFEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 9878268C4E; Thu, 27 Jun 2024 07:51:47 +0200 (CEST) Date: Thu, 27 Jun 2024 07:51:47 +0200 From: Christoph Hellwig To: Stuart Hayes Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J . Wysocki" , Martin Belanger , Oliver O'Halloran , Daniel Wagner , Keith Busch , Lukas Wunner , David Jeffery , Jeremy Allison , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: Re: [PATCH v7 2/4] driver core: separate function to shutdown one device Message-ID: <20240627055147.GB15415@lst.de> References: <20240626194650.3837-1-stuart.w.hayes@gmail.com> <20240626194650.3837-3-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240626194650.3837-3-stuart.w.hayes@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Jun 26, 2024 at 02:46:48PM -0500, Stuart Hayes wrote: > Make a separate function for the part of device_shutdown() that does the > shutown for a single device. This is in preparation for making device > shutdown asynchronous. > > Signed-off-by: Stuart Hayes > Signed-off-by: David Jeffery Looks good: Reviewed-by: Christoph Hellwig