From: Oleg Nesterov <oleg@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, brauner@kernel.org, mjguzik@gmail.com,
tandersen@netflix.com, linux-kernel@vger.kernel.org,
Mike Rapoport <rppt@kernel.org>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] kernel/fork.c: get totalram_pages from memblock to calculate max_threads
Date: Sun, 30 Jun 2024 09:51:04 +0200 [thread overview]
Message-ID: <20240630075103.GB11898@redhat.com> (raw)
In-Reply-To: <20240630062214.31707-1-richard.weiyang@gmail.com>
On 06/30, Wei Yang wrote:
>
> static void set_max_threads(unsigned int max_threads_suggested)
> {
> u64 threads;
> - unsigned long nr_pages = totalram_pages();
> + unsigned long nr_pages = PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size());
Can't comment, I don't understand this patch.
but if you change set_max_threads, perhaps you can mark it as __init
for consistency?
Oleg.
prev parent reply other threads:[~2024-06-30 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 6:22 Wei Yang
2024-06-30 7:51 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240630075103.GB11898@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=richard.weiyang@gmail.com \
--cc=rppt@kernel.org \
--cc=tandersen@netflix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®