From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E61AB75804 for ; Mon, 1 Jul 2024 07:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.112 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719817521; cv=none; b=iLdZh3DkZTr/gPtugsOFSe0AzGynlnuzJahbeUvIqaokCejVgGKLXvai9JUqOYESpPIGNbxsxPqRz1QYxEjnI3B5c/m6xYI4tVNOt7HFqkH5iTQE7xvf3N6zn/vLE/HjLSJv02ubwsSEqJut8WlhTQoQ/kxKTVaYRW8yyabi4L4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719817521; c=relaxed/simple; bh=Bq8cVolJEqVGxo+6frjA1OESCqD9VA5WT0OaW+jUYjU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SyYlr0KuTGb/4BQ1E2LTqWtiVRMUaeoYotZT3oW61D08GZB67AyqZ0ySo2c4Nf9qlTHo6eyK7wYjnsDfeTKSlSEGxrIeIRUhEMtUBhRDaMx2TlcUdYoaSOf89IXjiAVYcSVi4dFpORYJ9bC7sk1KvUeXHscmZY14TRdOQo4UZhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=F8OZ1+dY; arc=none smtp.client-ip=115.124.30.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="F8OZ1+dY" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1719817509; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=m5DOnA77mYO9Kov/acwk1k0qy5fyuGvG+StfdsLm5OQ=; b=F8OZ1+dYUjO9zNAbGgST1Km338UdtzdbuPCiY2AtwOktzptoEPCfXwB2JxrCjRMr3mZuT0NsrB+3Y9VUQqXai5q1TVlL8A+7dv5Q4KnbpMAeMwq35g/aApIxReeSFok2BsPO6NASOblJZn1vxSqQxY1pwggOcUfVw18J1lGDIQU= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067111;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0W9b27uN_1719817507; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W9b27uN_1719817507) by smtp.aliyun-inc.com; Mon, 01 Jul 2024 15:05:09 +0800 From: Jiapeng Chong To: harry.wentland@amd.com Cc: sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 2/4] drm/amd/display: Fix warning comparing pointer to 0 Date: Mon, 1 Jul 2024 15:04:53 +0800 Message-Id: <20240701070454.106083-3-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20240701070454.106083-1-jiapeng.chong@linux.alibaba.com> References: <20240701070454.106083-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Avoid pointer type value compared with 0 to make code clear. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_mcg/dml2_mcg_factory.c:19:12-13: WARNING comparing pointer to 0. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9458 Signed-off-by: Jiapeng Chong --- .../amd/display/dc/dml2/dml21/src/dml2_mcg/dml2_mcg_factory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_mcg/dml2_mcg_factory.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_mcg/dml2_mcg_factory.c index ce83c10253a2..55085b85f8ed 100644 --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_mcg/dml2_mcg_factory.c +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_mcg/dml2_mcg_factory.c @@ -16,7 +16,7 @@ bool dml2_mcg_create(enum dml2_project_id project_id, struct dml2_mcg_instance * { bool result = false; - if (out == 0) + if (!out) return false; memset(out, 0, sizeof(struct dml2_mcg_instance)); -- 2.20.1.7.g153144c