From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, "Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Marek Behún" <kabel@kernel.org>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org, "Nathan Chancellor" <nathan@kernel.org>,
"Antoine Tenart" <atenart@kernel.org>,
"Marc Kleine-Budde" <mkl@pengutronix.de>
Subject: [PATCH net-next v13 00/13] Introduce PHY listing and link_topology tracking
Date: Mon, 1 Jul 2024 15:17:46 +0200 [thread overview]
Message-ID: <20240701131801.1227740-1-maxime.chevallier@bootlin.com> (raw)
Hello everyone,
This is V14 on the phy_link_topology series, aiming at supporting
ethernet devices where multiple PHYs sit between the MAC and the
front-facing port. I've addressed comments, reviews and bug reports in
that series (thanks Jakub, Andrew, Russell and Marc for stepping-in for
V13 review, tests and discussions).
The notable changes in V14 are :
- Fixed some typos reported by Jakub
- Don't copy the phy_device_node in the dump iterations (patch 7)
- Don't call ethnl_parse_header_dev_put() inconditionally for dumps
(Thanks Marc for the report) (patch 7)
- Don't store the phy_device pointer in the ethnl_req_info, instead
only store the index (patch 5)
- Add dedicated helper to get the phy from the req_info, enforcing
rtnl_lock() to be held (patch 5)
- Make use of that header in commands that rely on it (patches 9 to 12)
Due to the rework of the way we get the phy_device from the ethnl
request, I dropped the reviewed-by on patches 9 to 12 as well as on
patches 5 and 7 that were heavily reworked.
As a remainder, here's what the PHY listings would look like :
- eth0 has a 88x3310 acting as media converter, and an SFP module with
an embedded 88e1111 PHY
- eth2 has a 88e1510 PHY
# ethtool --show-phys *
PHY for eth0:
PHY index: 1
Driver name: mv88x3310
PHY device name: f212a600.mdio-mii:00
Downstream SFP bus name: sfp-eth0
PHY id: 0
Upstream type: MAC
PHY for eth0:
PHY index: 2
Driver name: Marvell 88E1111
PHY device name: i2c:sfp-eth0:16
PHY id: 21040322
Upstream type: PHY
Upstream PHY index: 1
Upstream SFP name: sfp-eth0
PHY for eth2:
PHY index: 1
Driver name: Marvell 88E1510
PHY device name: f212a200.mdio-mii:00
PHY id: 21040593
Upstream type: MAC
Ethtool patches : https://github.com/minimaxwell/ethtool/tree/mc/topo-v14
Link to V13: https://lore.kernel.org/netdev/20240607071836.911403-1-maxime.chevallier@bootlin.com/
Link to v12: https://lore.kernel.org/netdev/20240605124920.720690-1-maxime.chevallier@bootlin.com/
Link to v11: https://lore.kernel.org/netdev/20240404093004.2552221-1-maxime.chevallier@bootlin.com/
Link to V10: https://lore.kernel.org/netdev/20240304151011.1610175-1-maxime.chevallier@bootlin.com/
Link to V9: https://lore.kernel.org/netdev/20240228114728.51861-1-maxime.chevallier@bootlin.com/
Link to V8: https://lore.kernel.org/netdev/20240220184217.3689988-1-maxime.chevallier@bootlin.com/
Link to V7: https://lore.kernel.org/netdev/20240213150431.1796171-1-maxime.chevallier@bootlin.com/
Link to V6: https://lore.kernel.org/netdev/20240126183851.2081418-1-maxime.chevallier@bootlin.com/
Link to V5: https://lore.kernel.org/netdev/20231221180047.1924733-1-maxime.chevallier@bootlin.com/
Link to V4: https://lore.kernel.org/netdev/20231215171237.1152563-1-maxime.chevallier@bootlin.com/
Link to V3: https://lore.kernel.org/netdev/20231201163704.1306431-1-maxime.chevallier@bootlin.com/
Link to V2: https://lore.kernel.org/netdev/20231117162323.626979-1-maxime.chevallier@bootlin.com/
Link to V1: https://lore.kernel.org/netdev/20230907092407.647139-1-maxime.chevallier@bootlin.com/
More discussions on specific issues that happened in 6.9-rc:
https://lore.kernel.org/netdev/20240412104615.3779632-1-maxime.chevallier@bootlin.com/
https://lore.kernel.org/netdev/20240429131008.439231-1-maxime.chevallier@bootlin.com/
https://lore.kernel.org/netdev/20240507102822.2023826-1-maxime.chevallier@bootlin.com/
Maxime Chevallier (13):
net: phy: Introduce ethernet link topology representation
net: sfp: pass the phy_device when disconnecting an sfp module's PHY
net: phy: add helpers to handle sfp phy connect/disconnect
net: sfp: Add helper to return the SFP bus name
net: ethtool: Allow passing a phy index for some commands
netlink: specs: add phy-index as a header parameter
net: ethtool: Introduce a command to list PHYs on an interface
netlink: specs: add ethnl PHY_GET command set
net: ethtool: plca: Target the command to the requested PHY
net: ethtool: pse-pd: Target the command to the requested PHY
net: ethtool: cable-test: Target the command to the requested PHY
net: ethtool: strset: Allow querying phy stats by index
Documentation: networking: document phy_link_topology
Documentation/netlink/specs/ethtool.yaml | 62 ++++
Documentation/networking/ethtool-netlink.rst | 52 +++
Documentation/networking/index.rst | 1 +
.../networking/phy-link-topology.rst | 121 +++++++
MAINTAINERS | 1 +
drivers/net/phy/Makefile | 2 +-
drivers/net/phy/marvell-88x2222.c | 2 +
drivers/net/phy/marvell.c | 2 +
drivers/net/phy/marvell10g.c | 2 +
drivers/net/phy/phy_device.c | 48 +++
drivers/net/phy/phy_link_topology.c | 105 ++++++
drivers/net/phy/phylink.c | 3 +-
drivers/net/phy/qcom/at803x.c | 2 +
drivers/net/phy/qcom/qca807x.c | 2 +
drivers/net/phy/sfp-bus.c | 15 +-
include/linux/netdevice.h | 4 +-
include/linux/phy.h | 6 +
include/linux/phy_link_topology.h | 82 +++++
include/linux/sfp.h | 8 +-
include/uapi/linux/ethtool.h | 16 +
include/uapi/linux/ethtool_netlink.h | 21 ++
net/core/dev.c | 15 +
net/ethtool/Makefile | 3 +-
net/ethtool/cabletest.c | 35 +-
net/ethtool/netlink.c | 66 +++-
net/ethtool/netlink.h | 33 ++
net/ethtool/phy.c | 312 ++++++++++++++++++
net/ethtool/plca.c | 30 +-
net/ethtool/pse-pd.c | 30 +-
net/ethtool/strset.c | 24 +-
30 files changed, 1055 insertions(+), 50 deletions(-)
create mode 100644 Documentation/networking/phy-link-topology.rst
create mode 100644 drivers/net/phy/phy_link_topology.c
create mode 100644 include/linux/phy_link_topology.h
create mode 100644 net/ethtool/phy.c
--
2.45.1
next reply other threads:[~2024-07-01 13:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 13:17 Maxime Chevallier [this message]
2024-07-01 13:17 ` [PATCH net-next v14 01/13] net: phy: Introduce ethernet link topology representation Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 03/13] net: phy: add helpers to handle sfp phy connect/disconnect Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 04/13] net: sfp: Add helper to return the SFP bus name Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 05/13] net: ethtool: Allow passing a phy index for some commands Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 06/13] netlink: specs: add phy-index as a header parameter Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 07/13] net: ethtool: Introduce a command to list PHYs on an interface Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 08/13] netlink: specs: add ethnl PHY_GET command set Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 09/13] net: ethtool: plca: Target the command to the requested PHY Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 10/13] net: ethtool: pse-pd: " Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 11/13] net: ethtool: cable-test: " Maxime Chevallier
2024-07-01 13:17 ` [PATCH net-next v14 12/13] net: ethtool: strset: Allow querying phy stats by index Maxime Chevallier
2024-07-02 10:54 ` Simon Horman
2024-07-03 6:55 ` Maxime Chevallier
2024-07-03 19:12 ` Jakub Kicinski
2024-07-03 20:18 ` Simon Horman
2024-07-01 13:17 ` [PATCH net-next v14 13/13] Documentation: networking: document phy_link_topology Maxime Chevallier
2024-07-01 13:23 ` [PATCH net-next v13 00/13] Introduce PHY listing and link_topology tracking Maxime Chevallier
-- strict thread matches above, loose matches on Subject: below --
2024-06-07 7:18 Maxime Chevallier
2024-06-26 9:47 ` Marc Kleine-Budde
2024-06-26 10:01 ` Maxime Chevallier
2024-06-26 10:15 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701131801.1227740-1-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jesse.brandeburg@intel.com \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mkl@pengutronix.de \
--cc=mwojtas@chromium.org \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®