From: Andrew Morton <akpm@linux-foundation.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: Christoph Hellwig <hch@lst.de>,
Thorsten Blum <thorsten.blum@toblux.com>,
jack@suse.cz, surenb@google.com, linux-kernel@vger.kernel.org,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH] dma-buf: Remove unnecessary kmalloc() cast
Date: Tue, 2 Jul 2024 00:33:57 -0700 [thread overview]
Message-ID: <20240702003357.6bfd1d918c56d536bb664c37@linux-foundation.org> (raw)
In-Reply-To: <e0f384b0-6913-4224-a3ea-bdae784f5dab@amd.com>
On Tue, 2 Jul 2024 09:13:35 +0200 Christian König <christian.koenig@amd.com> wrote:
> yes that is
> intentionally a define and not an inline function.
>
> See this patch here which changed that:
>
> commit 2c321f3f70bc284510598f712b702ce8d60c4d14
> Author: Suren Baghdasaryan <surenb@google.com>
> Date: Sun Apr 14 19:07:31 2024 -0700
>
> mm: change inlined allocation helpers to account at the call site
Dang, yes, that was a regrettable change. But hardly the end of the
world. I do think each such alteration should have included a comment
to prevent people from going and cleaning them up.
next prev parent reply other threads:[~2024-07-02 7:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 1:12 Thorsten Blum
2024-07-02 6:26 ` Andrew Morton
2024-07-02 6:40 ` Christoph Hellwig
2024-07-02 7:13 ` Christian König
2024-07-02 7:33 ` Andrew Morton [this message]
2024-07-02 7:35 ` Christoph Hellwig
2024-07-02 15:15 ` Suren Baghdasaryan
2024-07-03 17:45 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702003357.6bfd1d918c56d536bb664c37@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=surenb@google.com \
--cc=thorsten.blum@toblux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®