From: Francesco Dolcini <francesco@dolcini.it>
To: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: [PATCH v1 1/2] arm64: dts: ti: Mark PCIe PERST# polarity active low in DT
Date: Wed, 3 Jul 2024 12:00:35 +0200 [thread overview]
Message-ID: <20240703100036.17896-2-francesco@dolcini.it> (raw)
In-Reply-To: <20240703100036.17896-1-francesco@dolcini.it>
From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
As the name indicates, PERST# is active low. Fix the DT description to
match the HW behaviour.
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 +-
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts | 2 +-
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts | 2 +-
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 2 +-
arch/arm64/boot/dts/ti/k3-am69-sk.dts | 6 +++---
arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 2 +-
arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 2 +-
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 6 +++---
arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 4 ++--
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts | 2 +-
arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 2 +-
arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 4 ++--
12 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 6bb1ad2e56ec..afefce706647 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -785,7 +785,7 @@ serdes0_pcie_link: phy@0 {
&pcie0_rc {
status = "okay";
- reset-gpios = <&exp1 5 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 5 GPIO_ACTIVE_LOW>;
phys = <&serdes0_pcie_link>;
phy-names = "pcie-phy";
num-lanes = <1>;
diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
index cc619bbec181..0ea5edb830cb 100644
--- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
+++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
@@ -86,7 +86,7 @@ &pcie0_rc {
num-lanes = <2>;
phys = <&serdes0 PHY_TYPE_PCIE 1>, <&serdes1 PHY_TYPE_PCIE 1>;
phy-names = "pcie-phy0","pcie-phy1";
- reset-gpios = <&main_gpio1 15 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&main_gpio1 15 GPIO_ACTIVE_LOW>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts
index b829f4bcab69..0a23c7f4e1cd 100644
--- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts
@@ -180,7 +180,7 @@ &pcie0_rc {
num-lanes = <1>;
phys = <&serdes0 PHY_TYPE_PCIE 1>;
phy-names = "pcie-phy0";
- reset-gpios = <&wkup_gpio0 27 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&wkup_gpio0 27 GPIO_ACTIVE_LOW>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
index 90dbe31c5b81..ba7bd40f1535 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
@@ -713,7 +713,7 @@ serdes0_usb_link: phy@2 {
&pcie1_rc {
status = "okay";
- reset-gpios = <&exp1 10 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 10 GPIO_ACTIVE_LOW>;
phys = <&serdes0_pcie_link>;
phy-names = "pcie-phy";
num-lanes = <2>;
diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
index 3f655852244e..c62ab4caf354 100644
--- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
@@ -1266,14 +1266,14 @@ serdes1_pcie_link: phy@0 {
&pcie0_rc {
status = "okay";
- reset-gpios = <&exp1 4 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 4 GPIO_ACTIVE_LOW>;
phys = <&serdes1_pcie_link>;
phy-names = "pcie-phy";
};
&pcie1_rc {
status = "okay";
- reset-gpios = <&exp1 5 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 5 GPIO_ACTIVE_LOW>;
phys = <&serdes0_pcie_link>;
phy-names = "pcie-phy";
num-lanes = <2>;
@@ -1281,7 +1281,7 @@ &pcie1_rc {
&pcie3_rc {
status = "okay";
- reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 6 GPIO_ACTIVE_LOW>;
phys = <&serdes0_pcie_link>;
phy-names = "pcie-phy";
num-lanes = <1>;
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index 6593c5da82c0..8cf336c2d5c5 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -445,7 +445,7 @@ serdes0_qsgmii_link: phy@1 {
&pcie1_rc {
status = "okay";
- reset-gpios = <&exp1 2 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 2 GPIO_ACTIVE_LOW>;
phys = <&serdes0_pcie_link>;
phy-names = "pcie-phy";
num-lanes = <2>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
index a2925555fe81..4c4fdda146ab 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
@@ -858,7 +858,7 @@ &pcie1_rc {
phy-names = "pcie-phy";
num-lanes = <2>;
max-link-speed = <3>;
- reset-gpios = <&main_gpio0 22 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&main_gpio0 22 GPIO_ACTIVE_LOW>;
};
&ufs_wrapper {
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 8230d53cd696..8709fb11bb6a 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -925,7 +925,7 @@ &mhdp {
&pcie0_rc {
status = "okay";
- reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 6 GPIO_ACTIVE_LOW>;
phys = <&serdes0_pcie_link>;
phy-names = "pcie-phy";
num-lanes = <1>;
@@ -933,7 +933,7 @@ &pcie0_rc {
&pcie1_rc {
status = "okay";
- reset-gpios = <&exp1 2 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 2 GPIO_ACTIVE_LOW>;
phys = <&serdes1_pcie_link>;
phy-names = "pcie-phy";
num-lanes = <2>;
@@ -941,7 +941,7 @@ &pcie1_rc {
&pcie2_rc {
status = "okay";
- reset-gpios = <&exp2 20 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp2 20 GPIO_ACTIVE_LOW>;
phys = <&serdes2_pcie_link>;
phy-names = "pcie-phy";
num-lanes = <2>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
index 89fbfb21e5d3..6dc9966b52a1 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
@@ -1179,7 +1179,7 @@ &pcie0_rc {
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&ekey_reset_pins_default>;
- reset-gpios = <&main_gpio0 72 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&main_gpio0 72 GPIO_ACTIVE_LOW>;
phys = <&serdes0_pcie_link>;
phy-names = "pcie-phy";
@@ -1190,7 +1190,7 @@ &pcie1_rc {
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&mkey_reset_pins_default>;
- reset-gpios = <&wkup_gpio0 11 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&wkup_gpio0 11 GPIO_ACTIVE_LOW>;
phys = <&serdes1_pcie_link>;
phy-names = "pcie-phy";
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
index c5a0b7cbb14f..0830cba9dc61 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
@@ -474,7 +474,7 @@ flash@0 {
&pcie1_rc {
status = "okay";
- reset-gpios = <&exp1 2 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 2 GPIO_ACTIVE_LOW>;
phys = <&serdes0_pcie_link>;
phy-names = "pcie-phy";
num-lanes = <1>;
diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
index dd3b5f7039d7..001c6fe7e95e 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
@@ -522,7 +522,7 @@ serdes1_pcie_link: phy@0 {
};
&pcie0_rc {
- reset-gpios = <&exp1 18 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 18 GPIO_ACTIVE_LOW>;
phys = <&serdes1_pcie_link>;
phy-names = "pcie-phy";
status = "okay";
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index 9338d987180d..e3a393740997 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -1406,7 +1406,7 @@ &serdes_wiz0 {
&pcie1_rc {
status = "okay";
num-lanes = <2>;
- reset-gpios = <&exp1 2 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 2 GPIO_ACTIVE_LOW>;
phys = <&serdes0_pcie1_link>;
phy-names = "pcie-phy";
};
@@ -1429,7 +1429,7 @@ &serdes_wiz1 {
&pcie0_rc {
status = "okay";
- reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&exp1 6 GPIO_ACTIVE_LOW>;
phys = <&serdes1_pcie0_link>;
phy-names = "pcie-phy";
};
--
2.39.2
next prev parent reply other threads:[~2024-07-03 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 10:00 [PATCH v1 0/2] PCI: ti: k3: Fix TI J721E PERST# polarity Francesco Dolcini
2024-07-03 10:00 ` Francesco Dolcini [this message]
2024-07-03 10:00 ` [PATCH v1 2/2] PCI: j721e: Fix " Francesco Dolcini
2024-07-06 6:44 ` [PATCH v1 0/2] PCI: ti: k3: Fix TI J721E " Siddharth Vadapalli
2024-07-11 14:21 ` Niklas Cassel
2024-07-11 15:25 ` Francesco Dolcini
2024-07-12 10:34 ` Niklas Cassel
2024-07-12 10:40 ` Niklas Cassel
2024-08-06 14:35 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703100036.17896-2-francesco@dolcini.it \
--to=francesco@dolcini.it \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emanuele.ghidoli@toradex.com \
--cc=francesco.dolcini@toradex.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®