From: Utsav Agarwal via B4 Relay <devnull+utsav.agarwal.analog.com@kernel.org>
To: "Utsav Agarwal" <utsav.agarwal@analog.com>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Arturs Artamonovs <arturs.artamonovs@analog.com>,
Vasileios Bimpikas <vasileios.bimpikas@analog.com>,
Oliver Gaskell <oliver.gaskell@analog.com>
Subject: [PATCH v7 3/3] dt-bindings: input: Update dtbinding for adp5588
Date: Thu, 04 Jul 2024 14:03:55 +0100 [thread overview]
Message-ID: <20240704-adp5588_gpio_support-v7-3-e34eb7eba5ab@analog.com> (raw)
In-Reply-To: <20240704-adp5588_gpio_support-v7-0-e34eb7eba5ab@analog.com>
From: Utsav Agarwal <utsav.agarwal@analog.com>
Updating dt bindings for adp5588. Since the device can now function in a
purely gpio mode, the following keypad specific properties are now made
optional:
- interrupts
- keypad,num-rows
- keypad,num-columns
- linux,keymap
However the above properties are required to be specified when
configuring the device as a keypad, dependencies have been added
such that specifying either one would require the remaining as well.
Note that interrupts are optional, but required when the device has been
configured in keypad mode.
Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>
---
.../devicetree/bindings/input/adi,adp5588.yaml | 46 +++++++++++++++++++---
1 file changed, 41 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/adi,adp5588.yaml b/Documentation/devicetree/bindings/input/adi,adp5588.yaml
index 26ea66834ae2..481c37595ebb 100644
--- a/Documentation/devicetree/bindings/input/adi,adp5588.yaml
+++ b/Documentation/devicetree/bindings/input/adi,adp5588.yaml
@@ -49,7 +49,10 @@ properties:
interrupt-controller:
description:
This property applies if either keypad,num-rows lower than 8 or
- keypad,num-columns lower than 10.
+ keypad,num-columns lower than 10. This property is optional if
+ keypad,num-rows or keypad,num-columns are not specified since the
+ device then acts as gpio only, during which interrupts may or may
+ not be utilized.
'#interrupt-cells':
const: 2
@@ -65,13 +68,28 @@ properties:
minItems: 1
maxItems: 2
+
+dependencies:
+ keypad,num-rows:
+ - linux,keymap
+ - keypad,num-columns
+ keypad,num-columns:
+ - linux,keymap
+ - keypad,num-rows
+ linux,keymap:
+ - keypad,num-rows
+ - keypad,num-columns
+
+if:
+ required:
+ - linux,keymap
+then:
+ required:
+ - interrupts
+
required:
- compatible
- reg
- - interrupts
- - keypad,num-rows
- - keypad,num-columns
- - linux,keymap
unevaluatedProperties: false
@@ -108,4 +126,22 @@ examples:
>;
};
};
+
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/input/input.h>
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gpio@34 {
+ compatible = "adi,adp5588";
+ reg = <0x34>;
+
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+ };
+
...
--
2.34.1
next prev parent reply other threads:[~2024-07-04 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 13:03 [PATCH v7 0/3] adp5588-keys: Support for dedicated gpio operation Utsav Agarwal via B4 Relay
2024-07-04 13:03 ` [PATCH v7 1/3] Input: adp5588-keys - use guard notation when acquiring mutexes Utsav Agarwal via B4 Relay
2024-07-04 13:03 ` [PATCH v7 2/3] Input: adp5588-keys - add support for pure gpio Utsav Agarwal via B4 Relay
2024-07-04 13:03 ` Utsav Agarwal via B4 Relay [this message]
2024-07-04 13:36 ` [PATCH v7 3/3] dt-bindings: input: Update dtbinding for adp5588 Krzysztof Kozlowski
2024-07-04 14:12 ` Agarwal, Utsav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704-adp5588_gpio_support-v7-3-e34eb7eba5ab@analog.com \
--to=devnull+utsav.agarwal.analog.com@kernel.org \
--cc=arturs.artamonovs@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=oliver.gaskell@analog.com \
--cc=robh@kernel.org \
--cc=utsav.agarwal@analog.com \
--cc=vasileios.bimpikas@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®