Re: [PATCH v3 3/4] drm/bridge-connector: move to DRM_DISPLAY_HELPER module

[Maxime Ripard <mripard@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3216 bytes --]

On Tue, Jul 02, 2024 at 12:48:54PM GMT, Dmitry Baryshkov wrote:
> drm_bridge_connector is a "leaf" driver, belonging to the display
> helper, rather than the "CRTC" drm_kms_helper module. Move the driver
> to the drm/display and add necessary Kconfig selection clauses.
> 
> Suggested-by: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  drivers/gpu/drm/Makefile                             | 1 -
>  drivers/gpu/drm/bridge/Kconfig                       | 1 +
>  drivers/gpu/drm/display/Kconfig                      | 6 ++++++
>  drivers/gpu/drm/display/Makefile                     | 2 ++
>  drivers/gpu/drm/{ => display}/drm_bridge_connector.c | 0
>  drivers/gpu/drm/imx/dcss/Kconfig                     | 2 ++
>  drivers/gpu/drm/imx/lcdc/Kconfig                     | 2 ++
>  drivers/gpu/drm/ingenic/Kconfig                      | 2 ++
>  drivers/gpu/drm/kmb/Kconfig                          | 2 ++
>  drivers/gpu/drm/mediatek/Kconfig                     | 2 ++
>  drivers/gpu/drm/meson/Kconfig                        | 2 ++
>  drivers/gpu/drm/msm/Kconfig                          | 1 +
>  drivers/gpu/drm/omapdrm/Kconfig                      | 2 ++
>  drivers/gpu/drm/renesas/rcar-du/Kconfig              | 2 ++
>  drivers/gpu/drm/renesas/rz-du/Kconfig                | 2 ++
>  drivers/gpu/drm/renesas/shmobile/Kconfig             | 2 ++
>  drivers/gpu/drm/rockchip/Kconfig                     | 4 ++++
>  drivers/gpu/drm/tegra/Kconfig                        | 1 +
>  drivers/gpu/drm/tidss/Kconfig                        | 2 ++
>  drivers/gpu/drm/xlnx/Kconfig                         | 1 +
>  20 files changed, 38 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 68cc9258ffc4..fa432a1ac9e2 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -128,7 +128,6 @@ obj-$(CONFIG_DRM_TTM_HELPER) += drm_ttm_helper.o
>  drm_kms_helper-y := \
>  	drm_atomic_helper.o \
>  	drm_atomic_state_helper.o \
> -	drm_bridge_connector.o \
>  	drm_crtc_helper.o \
>  	drm_damage_helper.o \
>  	drm_encoder_slave.o \
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index c621be1a99a8..3eb955333c80 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -390,6 +390,7 @@ config DRM_TI_SN65DSI86
>  	depends on OF
>  	select DRM_DISPLAY_DP_HELPER
>  	select DRM_DISPLAY_HELPER
> +	select DRM_BRIDGE_CONNECTOR
>  	select DRM_KMS_HELPER
>  	select REGMAP_I2C
>  	select DRM_PANEL
> diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig
> index 479e62690d75..1a192a45961b 100644
> --- a/drivers/gpu/drm/display/Kconfig
> +++ b/drivers/gpu/drm/display/Kconfig
> @@ -6,6 +6,12 @@ config DRM_DISPLAY_HELPER
>  	help
>  	  DRM helpers for display adapters.
>  
> +config DRM_BRIDGE_CONNECTOR
> +	bool
> +	depends on DRM && DRM_BRIDGE && DRM_DISPLAY_HELPER
> +	help
> +	  DRM connector implementation terminating DRM bridge chains.
> +

Is there any reason to put it in there instead of under DRM_BRIDGE like
DRM_PANEL_BRIDGE?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]