mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Moreno <amorenoz@redhat.com>
To: netdev@vger.kernel.org
Cc: aconole@redhat.com, echaudro@redhat.com, horms@kernel.org,
	i.maximets@ovn.org, dev@openvswitch.org,
	Adrian Moreno <amorenoz@redhat.com>,
	Michal Kubiak <michal.kubiak@intel.com>,
	Ido Schimmel <idosch@nvidia.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH net-next v9 02/10] net: sched: act_sample: add action cookie to sample
Date: Thu,  4 Jul 2024 10:56:53 +0200	[thread overview]
Message-ID: <20240704085710.353845-3-amorenoz@redhat.com> (raw)
In-Reply-To: <20240704085710.353845-1-amorenoz@redhat.com>

If the action has a user_cookie, pass it along to the sample so it can
be easily identified.

Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Aaron Conole <aconole@redhat.com>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
---
 net/sched/act_sample.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c
index a69b53d54039..2ceb4d141b71 100644
--- a/net/sched/act_sample.c
+++ b/net/sched/act_sample.c
@@ -167,7 +167,9 @@ TC_INDIRECT_SCOPE int tcf_sample_act(struct sk_buff *skb,
 {
 	struct tcf_sample *s = to_sample(a);
 	struct psample_group *psample_group;
+	u8 cookie_data[TC_COOKIE_MAX_SIZE];
 	struct psample_metadata md = {};
+	struct tc_cookie *user_cookie;
 	int retval;
 
 	tcf_lastuse_update(&s->tcf_tm);
@@ -189,6 +191,16 @@ TC_INDIRECT_SCOPE int tcf_sample_act(struct sk_buff *skb,
 		if (skb_at_tc_ingress(skb) && tcf_sample_dev_ok_push(skb->dev))
 			skb_push(skb, skb->mac_len);
 
+		rcu_read_lock();
+		user_cookie = rcu_dereference(a->user_cookie);
+		if (user_cookie) {
+			memcpy(cookie_data, user_cookie->data,
+			       user_cookie->len);
+			md.user_cookie = cookie_data;
+			md.user_cookie_len = user_cookie->len;
+		}
+		rcu_read_unlock();
+
 		md.trunc_size = s->truncate ? s->trunc_size : skb->len;
 		psample_sample_packet(psample_group, skb, s->rate, &md);
 
-- 
2.45.2


  parent reply	other threads:[~2024-07-04  8:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04  8:56 [PATCH net-next v9 00/10] net: openvswitch: Add sample multicasting Adrian Moreno
2024-07-04  8:56 ` [PATCH net-next v9 01/10] net: psample: add user cookie Adrian Moreno
2024-07-04  8:56 ` Adrian Moreno [this message]
2024-07-04  8:56 ` [PATCH net-next v9 03/10] net: psample: skip packet copy if no listeners Adrian Moreno
2024-07-04  8:56 ` [PATCH net-next v9 04/10] net: psample: allow using rate as probability Adrian Moreno
2024-07-04  8:56 ` [PATCH net-next v9 05/10] net: openvswitch: add psample action Adrian Moreno
2024-07-04  8:56 ` [PATCH net-next v9 06/10] net: openvswitch: store sampling probability in cb Adrian Moreno
2024-07-04  8:56 ` [PATCH net-next v9 07/10] selftests: openvswitch: add psample action Adrian Moreno
2024-07-04  8:56 ` [PATCH net-next v9 08/10] selftests: openvswitch: add userspace parsing Adrian Moreno
2024-07-04  8:57 ` [PATCH net-next v9 09/10] selftests: openvswitch: parse trunc action Adrian Moreno
2024-07-04  8:57 ` [PATCH net-next v9 10/10] selftests: openvswitch: add psample test Adrian Moreno
2024-07-05  9:49 ` [PATCH net-next v9 00/10] net: openvswitch: Add sample multicasting Adrián Moreno
     [not found] ` <f73l6iiysjulc6eb2j3gm7ng4gkpe2uebnjiaun4fhhaogyp23@u3hi32mc4jvb>
2024-07-05 13:58   ` Adrián Moreno
2024-07-06  1:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240704085710.353845-3-amorenoz@redhat.com \
    --to=amorenoz@redhat.com \
    --cc=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=echaudro@redhat.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=idosch@nvidia.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.kubiak@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®