mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abhinav Jain <jain.abhinav177@gmail.com>
To: javier.carrasco.cruz@gmail.com
Cc: airlied@gmail.com, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, jain.abhinav177@gmail.com,
	julia.lawall@inria.fr, linux-kernel@vger.kernel.org,
	p.zabel@pengutronix.de, skhan@linuxfoundation.org
Subject: Re: [PATCH] gpu: ipu-v3: Removal of of_node_put with __free for auto cleanup
Date: Thu,  4 Jul 2024 13:26:17 +0000	[thread overview]
Message-ID: <20240704132617.1003914-1-jain.abhinav177@gmail.com> (raw)
In-Reply-To: <035757b1-5dc5-4966-9eaf-a52b707bd48e@gmail.com>

On Tue, 2 Jul 2024 17:29:14 +0200, Javier Carrasco wrote:
> Hi Abhinav,
>
> Apart form having sent two different patches with the same title (hence
> the confusion), this cleanup is right from a functional point of view.
>
> On the other hand, the description should address why you are doing this
> cleanup (e.g. to remove the need for explicit of_node_put() when the
> variable goes out of scope). The need for of_node_put() does no vanish,
> it is only automated and no longer visible at first glance by means of
> the cleanup attribute.
>
> Best regards,
> Javier Carrasco

Hi Javier,

Thank you for the detailed feedback. I have modified the patch subject as
well as the commit description to better fit the cleanup task being done.

PATCH v2:
https://lore.kernel.org/all/20240704132142.1003887-1-jain.abhinav177@gmail.com/

Best Regards,
Abhinav Jain

  reply	other threads:[~2024-07-04 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 15:01 Abhinav Jain
2024-07-02 15:29 ` Javier Carrasco
2024-07-04 13:26   ` Abhinav Jain [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-07-02 14:48 Abhinav Jain
2024-07-02 15:08 ` Javier Carrasco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240704132617.1003914-1-jain.abhinav177@gmail.com \
    --to=jain.abhinav177@gmail.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®