mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lance Yang <ioworker0@gmail.com>
To: akpm@linux-foundation.org
Cc: ioworker0@gmail.com, 21cnbao@gmail.com,
	baolin.wang@linux.alibaba.com, david@redhat.com,
	dj456119@gmail.com, libang.li@antgroup.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	mingzhe.yang@ly.com, ryan.roberts@arm.com, shy828301@gmail.com,
	ziy@nvidia.com
Subject: Re: [PATCH v3 1/2] mm: add per-order mTHP split counters
Date: Fri,  5 Jul 2024 19:31:19 +0800	[thread overview]
Message-ID: <20240705113119.82210-1-ioworker0@gmail.com> (raw)
In-Reply-To: <CAK1f24=wK9Gpt71NtVCyM1RRQF0MDmhm4MViVj_gPx_+ywks7w@mail.gmail.com>

Hi Andrew,

Could you please fold the following changes into this patch?

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 993f0dd2a1ed..f8b5cbd4dd71 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3266,7 +3266,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
 		i_mmap_unlock_read(mapping);
 out:
 	xas_destroy(&xas);
-	if (order >= HPAGE_PMD_ORDER)
+	if (order == HPAGE_PMD_ORDER)
 		count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED);
 	count_mthp_stat(order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_FAILED);
 	return ret;

Thanks,
Lance

  reply	other threads:[~2024-07-05 11:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04  1:29 [PATCH v3 0/2] mm: introduce " Lance Yang
2024-07-04  1:29 ` [PATCH v3 1/2] mm: add " Lance Yang
2024-07-05  9:08   ` David Hildenbrand
2024-07-05 10:12     ` Barry Song
2024-07-05 10:14       ` David Hildenbrand
2024-07-05 10:48         ` Lance Yang
2024-07-05 10:55           ` David Hildenbrand
2024-07-05 11:19             ` Lance Yang
2024-07-05 11:31               ` Lance Yang [this message]
2024-07-04  1:29 ` [PATCH v3 2/2] mm: add docs for " Lance Yang
2024-07-05  9:09   ` David Hildenbrand
2024-07-05  9:16   ` Ryan Roberts
2024-07-05  9:25     ` David Hildenbrand
2024-07-05 11:08       ` Lance Yang
2024-07-07  1:36   ` Lance Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240705113119.82210-1-ioworker0@gmail.com \
    --to=ioworker0@gmail.com \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=dj456119@gmail.com \
    --cc=libang.li@antgroup.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingzhe.yang@ly.com \
    --cc=ryan.roberts@arm.com \
    --cc=shy828301@gmail.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®