From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FFA71459E8; Fri, 5 Jul 2024 13:53:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.166.238 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720187605; cv=none; b=gNu8UWMMtFNLD5t41BAwXkvnmcRR8pxemBXFZCi/rndJbxEBX4VWb6fyGEeg3jIHiyooVbw7MGwxop7kYjrCZLHoT8kAFGmgxsmQvf0q/In6UgBvzLCXKLoICch05F18tOpu+KtfEdo30XfgHJlBpe+6rTary5R+PR7vaP7/NOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720187605; c=relaxed/simple; bh=sm118sAxchGuKFASZW6P4OZONsrrpdlZZiLkYDBahYU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PBPI6FyN3HzQbP4C1bwqPT6783rNV5frh8yzJLhVXzRPh9bRL5I8aYbMdgh8iJWdR3IB83fzNg8sfJ2FE1WCEdzpBTnlSdQzdj8/dIgIn4ukcCLt2ge0KWK9TDK6M6IwfTiwmTfU4BLwx+5hcQiirrodO57up3vHKFBnisabKcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; arc=none smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 465DfQnK032117; Fri, 5 Jul 2024 06:52:53 -0700 Received: from ala-exchng02.corp.ad.wrs.com (ala-exchng02.wrs.com [147.11.82.254]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 405jp1hfp3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 05 Jul 2024 06:52:53 -0700 (PDT) Received: from ALA-EXCHNG02.corp.ad.wrs.com (147.11.82.254) by ALA-EXCHNG02.corp.ad.wrs.com (147.11.82.254) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 5 Jul 2024 06:52:52 -0700 Received: from pek-lpd-ccm6.wrs.com (147.11.136.210) by ALA-EXCHNG02.corp.ad.wrs.com (147.11.82.254) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Fri, 5 Jul 2024 06:52:50 -0700 From: Lizhi Xu To: CC: , , , , , Subject: Re: [syzbot] [ntfs3?] KASAN: slab-out-of-bounds Read in mi_enum_attr Date: Fri, 5 Jul 2024 21:52:50 +0800 Message-ID: <20240705135250.3587041-1-lizhi.xu@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: mYGhZTdY-0RCetm-QbEqRWmKnBK1oLTg X-Proofpoint-ORIG-GUID: mYGhZTdY-0RCetm-QbEqRWmKnBK1oLTg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-05_09,2024-07-05_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1011 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 adultscore=0 phishscore=0 mlxlogscore=760 spamscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.21.0-2406140001 definitions=main-2407050099 On Thu, 4 Jul 2024 15:44:02 +0200, Dmitry Vyukov wrote: > > index 53629b1f65e9..a435df98c2b1 100644 > > --- a/fs/ntfs3/record.c > > +++ b/fs/ntfs3/record.c > > @@ -243,14 +243,14 @@ struct ATTRIB *mi_enum_attr(struct mft_inode *mi, struct ATTRIB *attr) > > off += asize; > > } > > > > - asize = le32_to_cpu(attr->size); > > - > > /* Can we use the first field (attr->type). */ > > if (off + 8 > used) { > > static_assert(ALIGN(sizeof(enum ATTR_TYPE), 8) == 8); > > return NULL; > > } > > > > + asize = le32_to_cpu(attr->size); > > + > > if (attr->type == ATTR_END) { > > /* End of enumeration. */ > > return NULL; > > Hi Lizhi, > > I don't see this fix mailed as a patch. Do you plan to submit it officially? Hi Dmitry Vyukov, Here: https://lore.kernel.org/all/20240202033334.1784409-1-lizhi.xu@windriver.com -- Lizhi