From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, mst@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
pbonzini@redhat.com, stefanha@redhat.com, hare@suse.de,
kbusch@kernel.org, hch@lst.de
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux.dev,
John Garry <john.g.garry@oracle.com>
Subject: [PATCH v2 0/5] Validate logical block size in blk_validate_limits()
Date: Mon, 8 Jul 2024 09:16:46 +0000 [thread overview]
Message-ID: <20240708091651.177447-1-john.g.garry@oracle.com> (raw)
This series adds validation of the logical block size in
blk_validate_limits().
Some drivers had already been validating this themselves. As such, we can
mostly drop that driver validation.
nbd is problematic, as we cannot only change to just stop calling
blk_validate_limits(). This is because the LBS is updated in a 2-stage
process:
a. update block size in the driver and validate
b. update queue limits
So if we stop validating the limits in a., there is a user-visible change
in behaviour (as we stop rejecting invalid limits from the NBD_SET_BLKSIZE
ioctl). So I left that untouched.
This topic was originally mentioned in [0] and then again in [1] by
Keith.
I have also included a related virtio_blk change to deal with
blk_size config fallback.
[0] https://lore.kernel.org/linux-block/10b3e3fe-6ad5-4e0e-b822-f51656c976ee@oracle.com/
[1] https://lore.kernel.org/linux-block/Zl4dxaQgPbw19Irk@kbusch-mbp.dhcp.thefacebook.com/
Differences to v1:
- Add RB tags (thanks!)
- Update comment on blk_validate_block_size() and add print in
blk_validate_limits()
John Garry (5):
virtio_blk: Fix default logical block size fallback
block: Validate logical block size in blk_validate_limits()
null_blk: Don't bother validating blocksize
virtio_blk: Don't bother validating blocksize
loop: Don't bother validating blocksize
block/blk-settings.c | 4 ++++
drivers/block/loop.c | 12 +-----------
drivers/block/null_blk/main.c | 3 ---
drivers/block/virtio_blk.c | 31 +++++++++++--------------------
include/linux/blkdev.h | 1 +
5 files changed, 17 insertions(+), 34 deletions(-)
--
2.31.1
next reply other threads:[~2024-07-08 9:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 9:16 John Garry [this message]
2024-07-08 9:16 ` [PATCH v2 1/5] virtio_blk: Fix default logical block size fallback John Garry
2024-07-08 9:16 ` [PATCH v2 2/5] block: Validate logical block size in blk_validate_limits() John Garry
2024-07-09 5:38 ` Damien Le Moal
2024-07-08 9:16 ` [PATCH v2 3/5] null_blk: Don't bother validating blocksize John Garry
2024-07-09 0:12 ` Zhu Yanjun
2024-07-09 5:39 ` Damien Le Moal
2024-07-08 9:16 ` [PATCH v2 4/5] virtio_blk: " John Garry
2024-07-09 5:39 ` Damien Le Moal
2024-07-08 9:16 ` [PATCH v2 5/5] loop: " John Garry
2024-07-09 5:39 ` Damien Le Moal
2024-07-09 6:01 ` [PATCH v2 0/5] Validate logical block size in blk_validate_limits() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708091651.177447-1-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=eperezma@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®