From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5A81149C43 for ; Mon, 8 Jul 2024 18:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720461950; cv=none; b=cnRFwcpMWNt1KSUTieJZOJDg0wYqWKkL5o7Z13FEotztgnIizVghPW3KIidOtqzOawhe+6EJ3knZdEWsKtVr9dLG5IFopklz9EE+//IWCJbHtGp/9r/Mizxiu34sAYCLQiBYY+TRt+H4KkNoiiUm3rEra0oOpIfUmH/O0rpoOkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720461950; c=relaxed/simple; bh=8RLjAkvbd9deEwBz/GOWHSJSSqFw/q5XUI9esz1VxSg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QJnlvOSynutAIuzRTustRuxHBqeiwaXluFD6UiSOcRaDuKWZMfDqdf1oosLoAHIXiqxTSzdW/RIY3kvARIjN8uGRqZ02dQ5DHEF0PbrSG8+wbR97wTAhpDODI7M6PW7Bi6ll1gcxGfYWVpLM0rd1VE4bkD6pfn48wWivhvgB/GU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HimCvSTo; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HimCvSTo" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7035d5eec5aso1605715a34.1 for ; Mon, 08 Jul 2024 11:05:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720461948; x=1721066748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hxcirFeeuu0bt0rjz0tmui1G8RYDC+/JunVt8zPPRlg=; b=HimCvSToBRd0wyTWybX3iK/ljx9N7x5Kf6z/EztaEn00F9+Rc/ww6NWSERNxX9I4Dq u+UtQxi3iXxQNkDgvdHx1UcsqntPliN62vvsQ/GpcQJ4E0ypmkDJXAOVxHxd6mlNy6dc MOICnrtX6KhNXfaca8UTv6HI554B4n+jJx1IDSv4xX9gJeaJZsWWfunwwb1hcmouE2YD iqs1oXW97dkfpIPtsOx6NQSWjGMcvUbOxSUqfi+dLduw0+Nc6ghLHJvkcSnMMnX55gsI aQsIJitQOMgWfJpL9DFN3ZhRmfzZGNEIPU3akNE9B06+1casa95QtMuz3eJfAtGvIH6X Y7rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720461948; x=1721066748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hxcirFeeuu0bt0rjz0tmui1G8RYDC+/JunVt8zPPRlg=; b=Zd7PgRFpCrMXsaOjBFVANM6yFEicfzqJm6q/yqORNj5DPoUUBBz6SRGl0uh7nc5eXm 0SiysCvo2jBulJhyGRXgB2YMQMikD2yp1oqH0ZoA/wL212kuRC3H8LmD5Ol+AimjxkZO yucZ0+XeOwc3Na8OeSYgvfKCo+GdFNYiIXfpkQvbD4FuH9fvNyzZSPS2pl/p1HolJ/DT OWY1HBbEp+yr8ELsV2K8IkRDDBukoV6YlovFO9iRHCM3ODmt0JpZaeNpgEsY1uOlGoN2 3AF6EuD31t59iasKeeovUW3yJwiSqVQYFzGu4KPBj3AadNIr5TvKDkKNg+HNDkt9R8iB OKGA== X-Forwarded-Encrypted: i=1; AJvYcCWIakAndrSF+gxJ2Uz+EASibQmNocJVFOYyxIl/BwsIgJl4WvglnGG30mRjf6tyVo1VWAj8X3xMiclp9I5nTxB3b0rB7Uu8HSALA3Wp X-Gm-Message-State: AOJu0YwUiRg4E/ur4AkWeTYaRUQg7DjvsvnxdOi51CBbeub4rodMg3vW BbWCX2IQ4BubPm06H6v+oJfyKdXye1uSzoC+nF40jDp6p4l0miO8Pkett1/RZwA= X-Google-Smtp-Source: AGHT+IG8otGIAka26ozpbixMx1Ghd9XSCzhxkO203rOwzFDNLcLqz5bFlnD1pgUMtGdNE1fgcqq6yA== X-Received: by 2002:a05:6808:10d5:b0:3d9:3802:3855 with SMTP id 5614622812f47-3d93c02038bmr176901b6e.23.1720461947976; Mon, 08 Jul 2024 11:05:47 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:cdd0:d497:b7b2:fe]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3d93acff184sm76287b6e.10.2024.07.08.11.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 11:05:47 -0700 (PDT) From: Dan Carpenter To: Krishna chaitanya chundru Cc: Dan Carpenter , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] PCI: qcom: Prevent potential error pointer dereference Date: Mon, 8 Jul 2024 13:05:37 -0500 Message-ID: <20240708180539.1447307-3-dan.carpenter@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240708180539.1447307-1-dan.carpenter@linaro.org> References: <20240708180539.1447307-1-dan.carpenter@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Only call dev_pm_opp_put() if dev_pm_opp_find_freq_exact() succeeds. Otherwise it leads to an error pointer dereference. Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance") Signed-off-by: Dan Carpenter --- drivers/pci/controller/dwc/pcie-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 1d36311f9adb..e06c4ad3a72a 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1443,8 +1443,8 @@ static void qcom_pcie_icc_opp_update(struct qcom_pcie *pcie) if (ret) dev_err(pci->dev, "Failed to set OPP for freq (%lu): %d\n", freq_kbps * width, ret); + dev_pm_opp_put(opp); } - dev_pm_opp_put(opp); } } -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66D8E156238 for ; Tue, 9 Jul 2024 13:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720533566; cv=none; b=AAU/LSmkcyUske8cyBVLX2FsjlzbH2P7z7EOUnSfyjFh+36+NQGbVSiMX9CqlUAV3G+V7lyoEZZV45Xvnt2e6RNeSJs9pKE/5YbwmDidWQo2w/N+kOZnU/C5ZvrpDtfZTcXg1HjWo8jqq+jMJ/4oV9G4fo3iKQYXAybhh8kj0jY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720533566; c=relaxed/simple; bh=4ZY3sgg/UcXc1lHmildNgyCCyNnIQNIHYrRURZgokIA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GlRS7z1ltHH4wRRHedbrjtjhhmyVAn3Q+4xp7cUqS0ps3RF1kFOos6nWPfY0zLXOMJ0vw+afpYXCJiQnjp/JPs4hTtQ+WTmSU9l5Nv9lMEijKXtEyQ+QdCWfoqUmpmCHpOlIdv0slb1BJOvLbjjEF/FykrZxiDaaopO5052FKas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=fail (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HimCvSTo reason="signature verification failed"; arc=none smtp.client-ip=209.85.167.177; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HimCvSTo" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52e9fe05354so7600428e87.1 for ; Tue, 09 Jul 2024 06:59:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720533562; x=1721138362; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oBVMyiTluWvB+cspxCg8zTmg6u43rmW8xruXcjUcEz0=; b=pei0YhBP0XEvvH3Gef/BvCtTnrMZtV5oS82nO77U2ySy+4hkrKwFyvpfBc2zs5iAuv 4rd3EnSdX5Dj4I1oov4q/y/ozE9RGuzPLU2vZp04TEM6aSiBsl8bkTsCuRdAcep0kD7J JThHx33x3S1p1tS0wM50E+cdBUSOHACRTAnL5ff6h201Yg4iB3lPTA3O+qnrNhKXzvfz 8iG0azvntIRnDvbbQSpa+/t13iFZkBx8BQxMsMI045jxn2dZb7bK5F+crZ5L9lkvTVE2 wiB4SXJ5TxfBNp7mbE1JD9WYMqI78gmrGhcHsamlKe43NcZ6xWpB2rmkecPg4Umxfi+C U6Ow== X-Forwarded-Encrypted: i=1; AJvYcCV4o02gYvvyqkfVVQUiy1Z6rv/ZP/iVMlge01kT2EPuwE8rd6JLoWdWErKQqERuJJicuPHd5BGUG64BuzMzjV9jkBiwin9HVxqZlzn8 X-Gm-Message-State: AOJu0YxGpXOPIiEVAPAR51RUcI0kUgaHywo6RWoJtx8FCr7IJN3vwJdM MAp10RBvl0xjQVBgH9PVqAS8Xi4bAjreq8VCIqpW+rathTNrU6YQlfoBvg1QMJg= X-Google-Smtp-Source: AGHT+IG/rFtXKbzfzIclsUAgMeGPHLkGwdyOR4dLpOuhjgwOVsd7Rde9H5nBfdSfvRYOMEmvNTFStA== X-Received: by 2002:a19:5f03:0:b0:52e:934c:8e76 with SMTP id 2adb3069b0e04-52eb99a324amr1552711e87.41.1720533561657; Tue, 09 Jul 2024 06:59:21 -0700 (PDT) Received: from localhost (c-9b0ee555.07-21-73746f28.bbcust.telenor.se. [85.229.14.155]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52eb8e3473asm252107e87.36.2024.07.09.06.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 06:59:21 -0700 (PDT) From: Anders Roxell To: dan.carpenter@linaro.org, Krishna chaitanya chundru Cc: bhelgaas@google.com, kw@linux.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org, robh@kernel.org, Anders Roxell Subject: [PATCH 2/3] PCI: qcom: Prevent potential error pointer dereference Date: Tue, 9 Jul 2024 15:59:18 +0200 Message-ID: <20240708180539.1447307-3-dan.carpenter@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240708180539.1447307-1-dan.carpenter@linaro.org> References: <20240708180539.1447307-1-dan.carpenter@linaro.org> Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D48AB148FED for ; Mon, 8 Jul 2024 18:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3d92aa6b62bso1204955b6e.2 for ; Mon, 08 Jul 2024 11:05:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720461948; x=1721066748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hxcirFeeuu0bt0rjz0tmui1G8RYDC+/JunVt8zPPRlg=; b=HimCvSToBRd0wyTWybX3iK/ljx9N7x5Kf6z/EztaEn00F9+Rc/ww6NWSERNxX9I4Dq u+UtQxi3iXxQNkDgvdHx1UcsqntPliN62vvsQ/GpcQJ4E0ypmkDJXAOVxHxd6mlNy6dc MOICnrtX6KhNXfaca8UTv6HI554B4n+jJx1IDSv4xX9gJeaJZsWWfunwwb1hcmouE2YD iqs1oXW97dkfpIPtsOx6NQSWjGMcvUbOxSUqfi+dLduw0+Nc6ghLHJvkcSnMMnX55gsI aQsIJitQOMgWfJpL9DFN3ZhRmfzZGNEIPU3akNE9B06+1casa95QtMuz3eJfAtGvIH6X Y7rQ== X-Forwarded-Encrypted: i=1; AJvYcCVwkqYAK6ZlIVETdJ8PeCCcKNQFBLOYM+DRSFLgaiM1ECxyPZiHVwhel4bQLtJujradn601FDr1Yh33VRIJ/DMVc9/kp/BwodUj X-Received: by 2002:a05:6808:10d5:b0:3d9:3802:3855 with SMTP id 5614622812f47-3d93c02038bmr176901b6e.23.1720461947976; Mon, 08 Jul 2024 11:05:47 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:cdd0:d497:b7b2:fe]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3d93acff184sm76287b6e.10.2024.07.08.11.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 11:05:47 -0700 (PDT) X-Mailer: git-send-email 2.43.0 Precedence: bulk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: <20240709135918.wJIWda-Q3IPM-O0wfA6TPmZ3swyfkKgztooCAJf4nRg@z> From: Dan Carpenter > Only call dev_pm_opp_put() if dev_pm_opp_find_freq_exact() succeeds. > Otherwise it leads to an error pointer dereference. > > Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance") > Signed-off-by: Dan Carpenter Tested-by: Anders Roxell Applied this patch ontop of linux-next tag, next-20240709. Booted fine on dragonboard-845c HW. Cheers, Anders > --- > drivers/pci/controller/dwc/pcie-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 1d36311f9adb..e06c4ad3a72a 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1443,8 +1443,8 @@ static void qcom_pcie_icc_opp_update(struct qcom_pcie *pcie) > if (ret) > dev_err(pci->dev, "Failed to set OPP for freq (%lu): %d\n", > freq_kbps * width, ret); > + dev_pm_opp_put(opp); > } > - dev_pm_opp_put(opp); > } > } > > -- > 2.43.0