mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com
Cc: thepacketgeek@gmail.com, riel@surriel.com, horms@kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 0/3] netconsole: Fix potential race condition and improve code clarity
Date: Tue,  9 Jul 2024 07:43:58 -0700	[thread overview]
Message-ID: <20240709144403.544099-1-leitao@debian.org> (raw)

This patchset addresses a potential bug in netconsole where the netconsole
target is cleaned up before it is disabled. This sequence could lead to a
situation where an enabled target has an uninitialized netpoll structure,
potentially causing undefined behavior.

The main goals of this patchset are:

1. Correct the order of operations:
   - First, disable the netconsole target
   - Then, clean up the netpoll structure

2. Improve code readability:
   - Remove unnecessary casts
   - Eliminate redundant operations

These changes aim to enhance the reliability of netconsole by
eliminating the potential race condition and improve maintainability by
making the code more straightforward to understand and modify.

Breno Leitao (3):
  net: netconsole: Remove unnecessary cast from bool
  net: netconsole: Eliminate redundant setting of enabled field
  net: netconsole: Disable target before netpoll cleanup

 drivers/net/netconsole.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-07-09 14:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 14:43 Breno Leitao [this message]
2024-07-09 14:43 ` [PATCH net-next 1/3] net: netconsole: Remove unnecessary cast from bool Breno Leitao
2024-07-09 14:44 ` [PATCH net-next 2/3] net: netconsole: Eliminate redundant setting of enabled field Breno Leitao
2024-07-09 14:44 ` [PATCH net-next 3/3] net: netconsole: Disable target before netpoll cleanup Breno Leitao
2024-07-12  1:32   ` Jakub Kicinski
2024-07-12  2:00 ` [PATCH net-next 0/3] netconsole: Fix potential race condition and improve code clarity patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240709144403.544099-1-leitao@debian.org \
    --to=leitao@debian.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=riel@surriel.com \
    --cc=thepacketgeek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®