From: Kory Maincent <kory.maincent@bootlin.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>
Cc: Simon Horman <horms@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kory Maincent <kory.maincent@bootlin.com>
Subject: [PATCH net v3 0/2] net: pse-pd: Fix possible issues with a PSE supporting both c33 and PoDL
Date: Thu, 11 Jul 2024 15:55:17 +0200 [thread overview]
Message-ID: <20240711-fix_pse_pd_deref-v3-0-edd78fc4fe42@bootlin.com> (raw)
Although PSE controllers supporting both c33 and PoDL are not on the
market yet, we want to prevent potential issues from arising in the
future. Two possible issues could occur with a PSE supporting both c33
and PoDL:
- Setting the config for one type of PSE leaves the other type's config
null. In this case, the PSE core would return EOPNOTSUPP, which is not
the correct behavior.
- Null dereference of Netlink attributes as only one of the Netlink
attributes would be specified at a time.
This patch series contains two patches to fix these issues.
Changes in v3:
- Add a cover letter and the net prefix
Changes in v2:
- Add a patch to deal with null config
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Kory Maincent (2):
net: pse-pd: Do not return EOPNOSUPP if config is null
net: ethtool: pse-pd: Fix possible null-deref
drivers/net/pse-pd/pse_core.c | 4 ++--
net/ethtool/pse-pd.c | 8 +++++---
2 files changed, 7 insertions(+), 5 deletions(-)
---
base-commit: d7c199e77ef2fe259ad5b1beca5ddd6c951fcba2
change-id: 20240711-fix_pse_pd_deref-6a7d0de068a4
Best regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next reply other threads:[~2024-07-11 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 13:55 Kory Maincent [this message]
2024-07-11 13:55 ` [PATCH net v3 1/2] net: pse-pd: Do not return EOPNOSUPP if config is null Kory Maincent
2024-07-11 13:55 ` [PATCH net v3 2/2] net: ethtool: pse-pd: Fix possible null-deref Kory Maincent
2024-07-14 14:41 ` [PATCH net v3 0/2] net: pse-pd: Fix possible issues with a PSE supporting both c33 and PoDL patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711-fix_pse_pd_deref-v3-0-edd78fc4fe42@bootlin.com \
--to=kory.maincent@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®