mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v2 1/2] net: pse-pd: Do not return EOPNOSUPP if config is null
Date: Thu, 11 Jul 2024 09:43:00 +0100	[thread overview]
Message-ID: <20240711084300.GA8788@kernel.org> (raw)
In-Reply-To: <20240710114232.257190-1-kory.maincent@bootlin.com>

On Wed, Jul 10, 2024 at 01:42:30PM +0200, Kory Maincent wrote:
> For a PSE supporting both c33 and PoDL, setting config for one type of PoE
> leaves the other type's config null. Currently, this case returns
> EOPNOTSUPP, which is incorrect. Instead, we should do nothing if the
> configuration is empty.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE framework")
> ---
> 
> Changes in v2:
> - New patch to fix dealing with a null config.

Hi Kory,

A few thing from a process perspective:

1. As fixes, with fixes tags (good!), this patchset seems like it is
   appropriate for net rather than net-next. And indeed it applies
   to net but not net-next. However, the absence of a target tree
   confuses our CI which failed to apply the patchset to net-next.

   Probably this means it should be reposted, targeted at net.

   Subject: [Patch v3 net x/y] ...

   See: https://docs.kernel.org/process/maintainer-netdev.html

2. Please provide a cover letter for patch sets with more than one
   (but not just one) patch. That provides an overview of how
   the patches relate to each other. And a convenient anchor for
   feedback such as point 1 above.

...

  parent reply	other threads:[~2024-07-11  8:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 11:42 Kory Maincent
2024-07-10 11:42 ` [PATCH v2 2/2] net: ethtool: pse-pd: Fix possible null-deref Kory Maincent
2024-07-11  8:43 ` Simon Horman [this message]
2024-07-11  8:53   ` [PATCH v2 1/2] net: pse-pd: Do not return EOPNOSUPP if config is null Kory Maincent
2024-07-11 13:57     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240711084300.GA8788@kernel.org \
    --to=horms@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®