From: Petr Tesarik <petr.tesarik@suse.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Petr Tesarik <petr@tesarici.cz>,
Petr Tesarik <ptesarik@suse.com>
Subject: [PATCH] sysfs/cpu: Make crash_hotplug attribute world-readable
Date: Thu, 11 Jul 2024 12:34:09 +0200 [thread overview]
Message-ID: <20240711103409.319673-1-petr.tesarik@suse.com> (raw)
From: Petr Tesarik <ptesarik@suse.com>
There is no reason to restrict access to this attribute, as it merely
reports whether crash elfcorehdr is automatically updated on CPU hot
plug/unplug and/or online/offline events.
Note that since commit 79365026f8694 ("crash: add a new kexec flag for
hotplug support"), this maps to the same flag which is world-accessible
through /sys/devices/system/memory/crash_hotplug.
Signed-off-by: Petr Tesarik <ptesarik@suse.com>
---
drivers/base/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
index c61ecb0c2ae2..73d69791d0d3 100644
--- a/drivers/base/cpu.c
+++ b/drivers/base/cpu.c
@@ -308,7 +308,7 @@ static ssize_t crash_hotplug_show(struct device *dev,
{
return sysfs_emit(buf, "%d\n", crash_check_hotplug_support());
}
-static DEVICE_ATTR_ADMIN_RO(crash_hotplug);
+static DEVICE_ATTR_RO(crash_hotplug);
#endif
static void cpu_device_release(struct device *dev)
--
2.45.2
next reply other threads:[~2024-07-11 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 10:34 Petr Tesarik [this message]
2024-07-11 17:25 ` Petr Tesařík
2024-07-12 3:35 ` Baoquan He
2024-07-12 4:30 ` Sourabh Jain
2024-07-12 6:21 ` Petr Tesařík
2024-07-12 6:31 ` Sourabh Jain
2024-07-12 6:48 ` Petr Tesarik
2024-07-12 6:54 ` Sourabh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711103409.319673-1-petr.tesarik@suse.com \
--to=petr.tesarik@suse.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr@tesarici.cz \
--cc=ptesarik@suse.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®