From: Johannes Thumshirn <jth@kernel.org>
To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Qu Wenru <wqu@suse.com>, Filipe Manana <fdmanana@suse.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH v3 0/3] btrfs: more RAID stripe tree updates
Date: Fri, 12 Jul 2024 09:48:35 +0200 [thread overview]
Message-ID: <20240712-b4-rst-updates-v3-0-5cf27dac98a7@kernel.org> (raw)
Three further RST updates targeted for 6.11 (hopefully).
The first one is a reworked version of the scrub vs dev-replace deadlock
fix. It does have reviews from Josef and Qu but I'd love to head Filipe's
take on it.
The second one updates a stripe extent in case a write to a already
present logical address happens.
The third one correects assumptions in the delete code. My assumption was
that we are deleting a single stripe extent on each call to
btrfs_delete_stripe_extent(). But do_free_extent_accounting() passes in a
start address and range of bytes that is deleted, so we need to keep track
of how many bytes we already have deleted and update the loop accordingly.
NOTE:
The next big bug in RST is related to relocation. When relocation is
reading from disk (via relocate_file_extent_cluster() ->
page_cache_ra_unbounded()) we're trying to lookup logical addresses that
for some reason RST does not know about and this leads to a tree dump and
ultimately a panic afterwards.
---
Changes in v3:
- Add Qu's Reviewed-by on patch 3
- Change patch 2 to using write_extent_buffer() (and drop Qu's R-b again)
- Link to v2: https://lore.kernel.org/r/20240711-b4-rst-updates-v2-0-d7b8113d88b7@kernel.org
Changes in v2:
- Add Qu's Reviewed-by on patch 2
- Add patch 3
- Link to v1: https://lore.kernel.org/r/20240709-b4-rst-updates-v1-0-200800dfe0fd@kernel.org
---
Johannes Thumshirn (3):
btrfs: don't hold dev_replace rwsem over whole of btrfs_map_block
btrfs: replace stripe extents
btrfs: update stripe_extent delete loop assumptions
fs/btrfs/raid-stripe-tree.c | 38 ++++++++++++++++++++++++++++++++++++++
fs/btrfs/volumes.c | 28 +++++++++++++++++-----------
2 files changed, 55 insertions(+), 11 deletions(-)
---
base-commit: 584df860cac6e35e364ada101ccd13495b954644
change-id: 20240709-b4-rst-updates-bb9c0e49cd5b
Best regards,
--
Johannes Thumshirn <jth@kernel.org>
next reply other threads:[~2024-07-12 7:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 7:48 Johannes Thumshirn [this message]
2024-07-12 7:48 ` [PATCH v3 1/3] btrfs: don't hold dev_replace rwsem over whole of btrfs_map_block Johannes Thumshirn
2024-07-15 11:29 ` Filipe Manana
2024-07-15 11:38 ` Johannes Thumshirn
2024-07-12 7:48 ` [PATCH v3 2/3] btrfs: replace stripe extents Johannes Thumshirn
2024-07-12 10:19 ` Qu Wenruo
2024-07-18 15:35 ` David Sterba
2024-07-12 7:48 ` [PATCH v3 3/3] btrfs: update stripe_extent delete loop assumptions Johannes Thumshirn
2024-07-15 12:41 ` [PATCH v3 0/3] btrfs: more RAID stripe tree updates David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712-b4-rst-updates-v3-0-5cf27dac98a7@kernel.org \
--to=jth@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®