From: Conor Dooley <conor.dooley@microchip.com>
To: <linux-spi@vger.kernel.org>
Cc: <conor@kernel.org>, <conor.dooley@microchip.com>,
Steve Wilkins <steve.wilkins@raymarine.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v1 5/6] spi: microchip-core: ensure TX and RX FIFOs are empty at start of a transfer
Date: Mon, 15 Jul 2024 12:13:56 +0100 [thread overview]
Message-ID: <20240715-flammable-provoke-459226d08e70@wendy> (raw)
In-Reply-To: <20240715-retail-magnolia-bbd49a657a89@wendy>
From: Steve Wilkins <steve.wilkins@raymarine.com>
While transmitting with rx_len == 0, the RX FIFO is not going to be
emptied in the interrupt handler. A subsequent transfer could then
read crap from the previous transfer out of the RX FIFO into the
start RX buffer. The core provides a register that will empty the RX and
TX FIFOs, so do that before each transfer.
Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers")
Signed-off-by: Steve Wilkins <steve.wilkins@raymarine.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
drivers/spi/spi-microchip-core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
index 3d17018cedb08..9f37603ccf10a 100644
--- a/drivers/spi/spi-microchip-core.c
+++ b/drivers/spi/spi-microchip-core.c
@@ -91,6 +91,8 @@
#define REG_CONTROL2 (0x28)
#define REG_COMMAND (0x2c)
#define COMMAND_CLRFRAMECNT BIT(4)
+#define COMMAND_TXFIFORST BIT(3)
+#define COMMAND_RXFIFORST BIT(2)
#define REG_PKTSIZE (0x30)
#define REG_CMD_SIZE (0x34)
#define REG_HWSTATUS (0x38)
@@ -493,6 +495,8 @@ static int mchp_corespi_transfer_one(struct spi_controller *host,
mchp_corespi_set_xfer_size(spi, (spi->tx_len > FIFO_DEPTH)
? FIFO_DEPTH : spi->tx_len);
+ mchp_corespi_write(spi, REG_COMMAND, COMMAND_RXFIFORST | COMMAND_TXFIFORST);
+
mchp_corespi_write(spi, REG_SLAVE_SELECT, spi->pending_slave_select);
while (spi->tx_len)
--
2.43.2
next prev parent reply other threads:[~2024-07-15 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 11:13 [PATCH v1 0/6] spi-microchip-core fixes & variable word size support Conor Dooley
2024-07-15 11:13 ` [PATCH v1 1/6] spi: microchip-core: fix the issues in the isr Conor Dooley
2024-07-15 11:13 ` [PATCH v1 2/6] spi: microchip-core: defer asserting chip select until just before write to TX FIFO Conor Dooley
2024-07-15 11:13 ` [PATCH v1 3/6] spi: microchip-core: only disable SPI controller when register value change requires it Conor Dooley
2024-07-15 11:13 ` [PATCH v1 4/6] spi: microchip-core: fix init function not setting the master and motorola modes Conor Dooley
2024-07-15 11:13 ` Conor Dooley [this message]
2024-07-15 11:13 ` [PATCH v1 6/6] spi: microchip-core: add support for word sizes of 1 to 32 bits Conor Dooley
2024-07-16 13:26 ` [PATCH v1 0/6] spi-microchip-core fixes & variable word size support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715-flammable-provoke-459226d08e70@wendy \
--to=conor.dooley@microchip.com \
--cc=broonie@kernel.org \
--cc=conor@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=steve.wilkins@raymarine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®